App: [$250] Playback speed is not displayed correctly in video player

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Version Number: 1.4.63-7 Reproducible in staging?: y Reproducible in production?: y If this was caught during regression testing, add the test name, ID and link from TestRail: Email or phone of affected tester (no customers): Logs: https://stackoverflow.com/c/expensify/questions/4856 Expensify/Expensify Issue URL: Issue reported by: @blimpich / @KMichel1030 Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1713565240359109

Action Performed:

Upload two videos(Video1, Video2).
Play Video1.
Then change playback speed to 0.25 (or any other)
Play Video2.
Check playback speed of Video2 (three dot menu -> playback speed).

Expected Result:

Playback speed of Video2 should be displayed as 1

Actual Result:

Video2 is played at speed 1 but playback speed is displayed as 0.25

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

https://github.com/Expensify/App/assets/38435837/79a8d3df-7d6a-4244-8de7-a96bb5ee10a1

https://github.com/Expensify/App/assets/38435837/81d22c16-b827-4e9b-b150-acb95d087a3e

View all open jobs on GitHub

Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~01648564b9cecf0115
Upwork Job ID: 1781837388056326144
Last Price Increase: 2024-04-24
Automatic offers:

hungvu193 | Contributor | 0

About this issue

Original URL
State: open
Created 2 months ago
Comments: 93 (77 by maintainers)

Most upvoted comments

Thank you both. I see the issue now. I agree that we should have a separate ref, because of that @KMichel1030 's main proposal looks good to me!. cc @blimpich

hungvu193 on Apr 25, 2024

Taking over this as C+ per this discussion

https://expensify.enterprise.slack.com/archives/C02NK2DQWUX/p1713787155736399

Cc @ntdiary

hungvu193 on Apr 22, 2024

@KMichel1030 please feel free to raise a PR. The bug zero team members will make sure you get paid once the PR is up and merged.

Please follow the steps here so that the process of assigning a contract to you can be automatic in the future.

blimpich on Apr 25, 2024

@hungvu193 Oh, I’m sorry. I found failed cases. I will check more and let you know.

KMichel1030 on Apr 25, 2024

@hungvu193 I will share my code diff soon.

And don’t forget to update your proposal along with it. Thank you/

hungvu193 on Apr 25, 2024

@hungvu193 Could you please add below part here?

videoPlayerRef.current?.getStatusAsync().then((status) => {
            if (!('rate' in status && status.rate)) {
                return;
            }
            setCurrentPlaybackSpeed(status.rate as PlaybackSpeed);
        });

I’m sorry I added code diffs separately in my proposal.

KMichel1030 on Apr 24, 2024

Thanks @KMichel1030, your suggestion only added type to VideoPopoverMenuContext, it won’t change the result I tested.

~@shahinyan11 's proposal here looks good to me. 🎀 👀 🎀 C+ reviewed.~

Given the effort everyone is putting in here, may I request a raise for this issue? @blimpich, I think $250 is a reasonable amount. Please let me know what’s your thought 🙇

hungvu193 on Apr 25, 2024

Thanks everyone! I’m AFK for a while but will review ASAP!

hungvu193 on Apr 23, 2024

Proposal

Updated. Updated to work as expected . @hungvu193 Please check

shahinyan11 on Apr 23, 2024

@hungvu193 Thank you for your advice. I will follow contributing guide strictly from now on.

KMichel1030 on Apr 23, 2024

^^^ Ignore that, I was trying to assign @hungvu193 as the C+ for this issue since they took over. Please continue the proposal process and we can fix this later.

blimpich on Apr 22, 2024

📣 @hungvu193 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link Upwork job Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻 Keep in mind: Code of Conduct | Contributing 📖

melvin-bot[bot] on Apr 22, 2024

@hungvu193 I apologize, but my changes are very small and just concern the writing and adding supporting links to make the proposal more understandable. And there is also no long interval between my changes

shahinyan11 on Apr 22, 2024

I would expect it to be 0.25

blimpich on Apr 22, 2024