App: [$250] Implement Three Suggested Changes from Callstack
Background
Callstack is vendor that we’ve engaged to help with app performance. They’ve needed to delay our engagement until September, but in the mean time gave a few tips for us that they think would be helpful.
Suggested Changes
-
The @react-native-community/cli dep shouldn’t be added directly. It’s a transitive dependency of react-native.Note:No longer adding @react-native-community/cli directly in package.json -
Both underscore and lodash are used. These are big libraries with the same purpose so you can pick one instead (we suggest lodash in this case) -
Remove Intl polyfills (@formatjs/intl*) usage, which can add up to 6MB of unicode data into the JS bundle. The Hermes version you’re using supports Intl object by default, so polyfill is an unnecessary overhead
Game Plan
I’ll bring these up for discussions with engineering to verify that we should proceed, and then implement the changes that we greenlight.
About this issue
- Original URL
- State: closed
- Created 2 years ago
- Comments: 25 (14 by maintainers)
I’ll do it. Assigning myself now.
Whoops. Closing since this is now paid!
Thanks for helping test here @mananjadhav, @Expensify/contributor-management would any of you be willing to pay out this issue for @mananjadhav?
Applied @jboniface
@mananjadhav job post here: https://www.upwork.com/jobs/~0175fa858fa8779088