App: [$1000] VBA - Cannot select the checkbox when a valid field is being focused entering bank account manually
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Action Performed:
- Open Settings => Workspace => Choose any workspaces => Connect Bank Account => Connect Manually.
- Notice that
Routing Numberis being focused and no error is showed, click oncheck box - Again focus on the
Routing Numberand click oncheck box
Expected Result:
Checkbox should be selected and focused at the first click
Actual Result:
Checkbox is not selected when a valid field is focused for the first time
Workaround:
unknown
Platform:
Where is this issue occurring?
- Web
- iOS
- Android
- Desktop App
- Mobile Web
Version Number: 1.2.34-1 Reproducible in staging?: y Reproducible in production?: y Email or phone of affected tester (no customers): Logs: https://stackoverflow.com/c/expensify/questions/4856 Notes/Photos/Videos:
Expensify/Expensify Issue URL: Issue reported by: @hungvu193 Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1669819241231349
Upwork Automation - Do Not Edit
- Upwork Job URL: https://www.upwork.com/jobs/~01a77f27abe4f6fc46
- Upwork Job ID: 1603384341212991488
- Last Price Increase: 2022-12-15
About this issue
- Original URL
- State: closed
- Created 2 years ago
- Comments: 48 (38 by maintainers)
Settled!
👋 The tracking issue this was held on has been completed now. I just re-tested this issue and the checkbox is checked on first click now as expected. @muttmuure, I’ve removed the hold from this issue title, dropped it back to
daily, and you can proceed to process the $250 payment to @hungvu193 for this initial bug report.@trjExpensify do you want to handle this together since it seems like you put the callout to ensure form validation is consistent?
@mollfpr Sorry I’m still testing on it only first part is valid.
I think that how it works on web. When you press the checkbox, the input will lose its focus and now the checkbox has the focus. The issue is similar to https://github.com/Expensify/App/issues/12715, but it only fixes the ToS
TextLinkwithonMouseDownsimilar to @tienifr proposal but the checkbox still does not implement theonMouseDownsolution.https://github.com/Expensify/App/blob/a414d1a30c1726ae6dcfd44d4f28e1ccaf3b7cdf/src/pages/ReimbursementAccount/BankAccountManualStep.js#L128-L135
Why on native the input does not lose its focus? It’s because we set the
keyboardShouldPersistTapstohandled, which prevent the focus loss when a click inside the Form is handled, in this case the checkbox (or the ToS, or the fix the errors).Yah mon, posted here.