App: [$1000] The strikethrough on the "edited" label is not visible for Code Blocks, Quotes, and Headings when an edited message was deleted in offline mode on mobile apps.
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Action Performed:
- Open any chat in native mobile apps
- Send a code block, quote and heading (
Code Block/ > Quote / # Heading) - Edit the messages so that the “edited” label is visible
- Now switch to offline mode and delete the messages
- Observe the “edited” label
Expected Result:
The “edited” label should have a strikethrough on it as seen on web and mobile web
Actual Result:
The “edited” label does not have a strikethrough
Workaround:
Can the user still use Expensify without this being fixed? Have you informed them of the workaround?
Platforms:
Which of our officially supported platforms is this issue occurring on?
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
Version Number: 1.3.6 Reproducible in staging?: y Reproducible in production?: y If this was caught during regression testing, add the test name, ID and link from TestRail: Email or phone of affected tester (no customers): Logs: https://stackoverflow.com/c/expensify/questions/4856 Notes/Photos/Videos: Any additional supporting documentation
!
Expensify/Expensify Issue URL: Issue reported by: @pubudu-ranasinghe Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1682161364254109
Upwork Automation - Do Not Edit
- Upwork Job URL: https://www.upwork.com/jobs/~01fb84eccd46f00572
- Upwork Job ID: 1653351142673272832
- Last Price Increase: 2023-06-21
About this issue
- Original URL
- State: closed
- Created a year ago
- Comments: 29 (17 by maintainers)
@neil-marcellini there is contradiction between Expected OP & current behavior . More broken than before reporting it seems as per this comment -> https://github.com/Expensify/App/issues/18042#issuecomment-1532474781 We should wait for #17781 before moving forward.
Yes, you are right.
But it’s also true that the inline flex is the one that causing the strikethrough missing on both markdown and normal text, ONLY on Web. Removing it will solve the issue.
However, I’m not saying that is 100% a bad thing because now we are manually apply the strikethrough style to the edited text that will eventually solve this web only issue https://github.com/Expensify/App/issues/17181