App: [$1000] Markdown to HTML Conversion Issue with Code Blocks
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Action Performed:
Copy the following text (including code block and surrounding text): text ``` some text
code block
- send it to Slack or GitHub message or any app that accepts markdown
- copy the text from the message.
- past it to Expensify composer
- send the message to Expensify.
Expected Result:
The text “hi” and “some text” should be rendered as normal text, and the code block should be rendered as a separate code block. The code block delimiters (```) should be treated as normal text and not trigger the code block formatting.
Actual Result:
When the message is sent and rendered in Expensify, “some text” are incorrectly rendered as part of the code block. The code block text and the code block delimiters (```) are not recognized as intended, leading to the incorrect formatting of the message.
Workaround:
Can the user still use Expensify without this being fixed? Have you informed them of the workaround?
Platforms:
Which of our officially supported platforms is this issue occurring on?
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
Version Number: 1.3.17.0 Reproducible in staging?: y **Reproducible in production?😗*y If this was caught during regression testing, add the test name, ID and link from TestRail: Email or phone of affected tester (no customers): Logs: https://stackoverflow.com/c/expensify/questions/4856 Notes/Photos/Videos: Any additional supporting documentation
https://github.com/Expensify/App/assets/43996225/0bf30e11-0b9c-4bbb-b987-410a53fb12a1
https://github.com/Expensify/App/assets/43996225/36e7ef75-773b-48d0-b66c-b9fe45c1e4cf
Expensify/Expensify Issue URL: Issue reported by: @ahmdshrif Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1684316680405429
Upwork Automation - Do Not Edit
- Upwork Job URL: https://www.upwork.com/jobs/~01c2c3f62fe6eee04f
- Upwork Job ID: 1661561925969117184
- Last Price Increase: 2023-06-01
About this issue
- Original URL
- State: closed
- Created a year ago
- Comments: 29 (17 by maintainers)
@Victor-Nyagudi thanks for linking that issue, very useful!! I agree this seems like a very random edge case that doesn’t necessarily need to be fixed. Though I think it makes sense to keep issues like these in mind for the future so that we can maybe fix all at once instead of one-off markdown fixes.
@abdulrahuman5196 @jliexpensify do y’all think it makes sense to have some kind of markdown tracker for all the little tiny issues like this one & https://github.com/Expensify/App/issues/17196 - so if we have them all together we can try to fix a clump of issues and make sure nothing breaks, instead of thinking a bout these random edge cases 1 by 1?
@jliexpensify sorry for the delay! Yeah as you mentioned - I was just thinking a general tracking issue linking these two GHs
I created it here: https://github.com/Expensify/App/issues/20304
If you have any additional details you think we should add, please feel free! Otherwise I think we should close this one out