App: [$1000] [HOLD for payment 2023-06-13] Crash on split confirm
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
This is a follow up issue from https://github.com/Expensify/App/pull/17349#issuecomment-1537823597
Action Performed:
- (Precondition) Have the desktop app open but not logged in; optionally, throttle your network (see last step)
- Log in to web
- In a 1:1 DM, select
Send money - Copy the URL from the address bar
- Modify the URL so that it’s a deep link (replace
httpwithnew-expensify) and open it - Follow the deep link prompt to open it in desktop
- Enter an amount to split and click
Nextbutton very quickly (if you are not throttling your network)
Expected Result:
Split confirm page should open
Actual Result:
The app crashes
Workaround:
Can the user still use Expensify without this being fixed? Have you informed them of the workaround?
Platforms:
Which of our officially supported platforms is this issue occurring on?
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
Version Number: Reproducible in staging?: Reproducible in production?: If this was caught during regression testing, add the test name, ID and link from TestRail: Email or phone of affected tester (no customers): Logs: https://stackoverflow.com/c/expensify/questions/4856 Notes/Photos/Videos: Any additional supporting documentation
https://github.com/Expensify/App/assets/7277067/857bdb25-c2c2-43a8-93be-84f52fb75628
Expensify/Expensify Issue URL: Issue reported by: @aimane-chnaif Slack conversation:
Upwork Automation - Do Not Edit
- Upwork Job URL: https://www.upwork.com/jobs/~010f9b81ec5ac80063
- Upwork Job ID: 1668641221032722432
- Last Price Increase: 2023-06-13
About this issue
- Original URL
- State: closed
- Created a year ago
- Comments: 38 (31 by maintainers)
Proposal LGTM, @kowczarz you can proceed to open a PR. Thanks!
ok, proposal looks good. Maybe you can raise PR next week when @amyevans is back and confirm
@amyevans Desktop app should be auto-logged in if deep link comes from logged in web url. Not sure why that doesn’t work from your video. Btw, that’s out of topic for this issue.
Reproducible step makes sense. To reproduce easily even with fast network, 7. can be updated like this: 7. Enter amount and click Next button very quickly
Update: I approved the PR which fixes the bug I mentioned above (crash on Send money / Request money / Split bill), so we should be able to work on this issue once it has been merged.
We have over 1,000 open issues in the repo, so I don’t know off the top of my head if they’ve been reported yet haha. Could you post them in the #expensify-bugs Slack channel? Our QA team is better at spotting duplicates, and if they aren’t dupes they will create new issues for them.