github-actions-runner-operator: Finalization of pods not run when CR is deleted

Running kubectl apply -f .\gh-runners-linux.yaml creates the runners as expected in my GitHub organization. When I delete them though (using kubectl delete -f .\gh-runners-linux.yaml), the pods that contained the runners get stuck in a “Terminating” status.

NAMESPACE                        NAME                                              READY   STATUS        RESTARTS   AGE
github-action-runners            runner-pool-pod-fhthp                             0/3     Terminating   0          4m50s
github-action-runners            runner-pool-pod-wfs62                             0/3     Terminating   0          4m50s
github-actions-runner-operator   github-actions-runner-operator-59b9d486b5-t2p62   1/1     Running       0          5m26s

If I edit the pod and remove the finalizer (garo.tietoevry.com/runner-registration), the pod successfully deletes after saving that change. The runner is not being removed from my list of GitHub self hosted runners though as I would expect. Am I missing something here?

About this issue

Original URL
State: open
Created 3 years ago
Reactions: 3
Comments: 17

Most upvoted comments

Maybe the CR should have finalizer as well.

zhsj on Jul 12, 2021

@aroemen @duyhenryer I was able to delete them by removing the finalizers field. Patch the finalizers list to be null:

kubectl patch pod <POD_NAME> -n <NAMESPACE> -p '{"metadata":{"finalizers":null}}'

gabriellemadden on Jun 11, 2021

I was able to reproduce it. It’s an edge case when you delete the actual cr. In this case it’s gone and the cleanup step handling the finalization https://github.com/evryfs/github-actions-runner-operator/blob/master/controllers/githubactionrunner_controller.go#L116 is not reached.

<div> GitHub</div><div>evryfs/github-actions-runner-operator</div><div>K8S operator for scheduling github actions runner pods - evryfs/github-actions-runner-operator</div>

davidkarlsen on Mar 11, 2021