django-reversion: Really slow on large datasets

Hi there, so i am trying out django-reversion==1.8.7 + django 1.7 in my admin on a table that has about 300.000 records and its really slow when i click on recover deleted which i am assuming it will call get_deleted method.

I am using it on my development machine (vagrant) with 1 core and 4 GB RAM. Is there anything i can do to make this work? Is this supposed to work well for these many datasets?

Thanks

About this issue

Original URL
State: closed
Created 9 years ago
Comments: 16 (9 by maintainers)

Commits related to this issue

Dramatically improved performance of get_deleted() over large datasets. Refs #439 — committed to etianen/django-reversion by etianen 7 years ago

Most upvoted comments

I’m fighting deadlines at the moment, but a reversion release can be done next week.

On 16 November 2017 at 10:06, James Malone notifications@github.com wrote:

This is great and critical fix - will you be releasing this as an official ‘release’ any time soon? Thanks, JM

— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub https://github.com/etianen/django-reversion/issues/439#issuecomment-344875332, or mute the thread https://github.com/notifications/unsubscribe-auth/AAJFCCxRCGxEqsC8UaTy1kbMg1TjsbVwks5s3AkRgaJpZM4FjZoO .

etianen on Nov 20, 2017

Wow, that’s excellent!

That query has been slow for the entire history of django-reversion, and I couldn’t think of any way to improve it. You’ve done the world a fine service! 😄

On 14 September 2017 at 14:09, Alexey Paramonov notifications@github.com wrote:

Works blazing fast now, checked and confirmed.

— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub https://github.com/etianen/django-reversion/issues/439#issuecomment-329476461, or mute the thread https://github.com/notifications/unsubscribe-auth/AAJFCDUiLTLj-AbqqgF2JQ-7WTuwRaI9ks5siSVzgaJpZM4FjZoO .

etianen on Sep 14, 2017

Thanks for the detailed report!

I’ve just pushed an optimization to master that uses your JOIN for get_deleted(). Would you mind checking it out and seeing if it works as fast as your recoverlist_view hack?

etianen on Sep 14, 2017