tests: BlockchainTests format changed
With https://github.com/ethereum/tests/commit/f386934ce509fa0a4dbd1c68421b3361b01b2efa (and the corresponding deletion https://github.com/ethereum/tests/commit/f11c47462ffc48203b8b588ab35e9ccb3cc79e04#diff-1a427fc3f925eef4e65fb0650dc712f7 ) the format of the transactions in BlockchainTests changed, from signed to unsigned.
Was this breaking change was intended? It has rendered both https://github.com/kframework/evm-semantics and https://github.com/dapphub/dapptools/tree/master/src/hevm incapable of running these tests.
About this issue
- Original URL
- State: closed
- Created 5 years ago
- Comments: 46 (20 by maintainers)
Commits related to this issue
- tests: updated blockchaintests, see https://github.com/ethereum/tests/issues/637 — committed to holiman/go-ethereum by holiman 5 years ago
- tests: update test suite for istanbul (#20082) * update tests for istanbul * tests: updated blockchaintests, see https://github.com/ethereum/tests/issues/637 * tests: update again, hopefully fi... — committed to ethereum/go-ethereum by holiman 5 years ago
- tests: update test suite for istanbul (#20082) * update tests for istanbul * tests: updated blockchaintests, see https://github.com/ethereum/tests/issues/637 * tests: update again, hopefully fi... — committed to makerdao/go-ethereum by holiman 5 years ago
- Merge eth upstream (Alternative solution) (#386) * tests: expose internal RunNoVerify method (#20051) * all: make unit tests work with Go 1.13 (#20053) Most of these changes are related to the ... — committed to autonity/autonity by screwyprof 4 years ago
- tests: update test suite for istanbul (#20082) * update tests for istanbul * tests: updated blockchaintests, see https://github.com/ethereum/tests/issues/637 * tests: update again, hopefully fi... — committed to enriquefynn/go-ethereum by holiman 5 years ago
- Release 1.0 (#14) * core: log chain reorg/split metrics (#18950) * core: log chain reorg/split metrics * core: report 1-block reorgs on the metrics too * common: unify hex prefix check code ... — committed to nebulaai/nbai-node by czhang-nbai 3 years ago
Yes unmarshalling from JSON is usually automated based on some strong type, and it’s not always easy to declare a field as something abstract over both string and array type. The existing unmarshaller (deserialiser) in Hive was expecting a target type of array. The fix for me was to ignore the field as it is irrelevant for Hive, but I don’t know if that is always the case for others. I think yes there should be a consistent type. Perhaps add a NEW field to represent the case that the poststate is a hash, while omitting the existing array, so deserialisers can allow for the existing field to be declared as optional.
A stable master should be made available agreed.
Going to fix. BCGeneralStateTests already fixed.
Another issue is that some tests seem to have change the format of
postStateto be a hash (?) rather than a map, e.g. this and this. Not sure where to look for documentation on that, if it’s a mistake that needs fixing or us that need to update our parsing code.