israeli-bank-scrapers: Visa Cal wrong day of transaction, and missing fields

Hi, compared to the previous version of Visa Cal, I see a few differences:

image

  • The order of the fields was changed.
  • The chargedCurrency, identifier, and memo are missings.
  • The date and processedDate are different in one day, but according to the website, maybe now it is the right date:
    image

About this issue

  • Original URL
  • State: closed
  • Created a year ago
  • Comments: 16 (7 by maintainers)

Most upvoted comments

@erikash The best fix for processedDate IMHO is to covert to a “real” ISO date:

In src/scrapers/visa-cal.ts

- processedDate: transaction.debCrdDate,
+ processedDate: new Date(transaction.debCrdDate).toISOString(),

This will still assume that the system TZ is correct, but at least the field will have the timezone explicitly

Actually I suspect @baruchiro you might have a bug - I’m parsing the dates correctly assuming Asia/Jerusalem timezone in my package consuming israeli-bank-scrapers https://github.com/orzarchi/israeli-finance-scraper/blob/master/src/runCommand.ts#L12

@erikash Please see if you can help with the missing fields 🙏