redux-form-material-ui: Not working with @material-ui/core v1.0.0
Hello,
I think there is a problem with the recent v1.0.0-rc.0
, which renames the namespace from material-ui
to @material-ui/core
.
I didn’t follow the discussion so I cannot really say why this was made, but it broke this library.
Do you plan to update it to support v1.0.0-rc.0
?
Will you release a final version once v1.0.0 is final as well?
Thanks!
About this issue
- Original URL
- State: closed
- Created 6 years ago
- Reactions: 33
- Comments: 29 (2 by maintainers)
I believe PR #249 is ready to go, just need somebody with write permissions to approve it.
Is this going to be merged anytime soon? My dev. app was just broken as well by the update to v1.0.0
I have published new version on next, if no issues found will move this changes to master.
Closing this.
I no longer maintain this repo. @mihirsoni does.
If he has dropped the ball and someone else would like to be made a maintainer (such power comes with responsibility!), please let me know. Preferably also @ me on twitter to draw my attention.
+1, i just updated my app ui to material-ui v1.0.0. I would appreciate a lot if this would get the resource update. 10x.
@erikras @mihirsoni I just submitted a pull request to fix this issue.
Would you please review, merge and release an updated package if it is ok?
Thanks!
I know +1 is enough, but right now it’s very important to upgrade so please update with next beta and
@material-ui/core
. A lot of people use it.@andreapier Perhaps my testing is overly naive… I had only started my fork from the 5.0 branch, and then used:
yarn test
after making my changes. It shows 28 passing, and no failures. Then I got the /example/ index page running, and my basic user testing seemed fine.I forked from the
5.0
branch, and tried to keep the syntax changes to a minimum (as compared to @andreapier 's PR #248 )There is still some odd issue that I don’t quite understand when testing the
RadioGroup
component.@see #249
I did required changes locally to not wait for this, could submit a PR as well.