envoy: Quiche build failure under gcc

Quiche fails to build under gcc (9.2.x) with the following error:

FAIL: //test/extensions/grpc_credentials/aws_iam:aws_iam_grpc_credentials_test (see /build/tmp/_bazel_bazel/b570b5ccd0454dc9af9f65ab1833764d/execroot/envoy/bazel-out/k8-opt/testlogs/test/extensions/grpc_credentials/aws_iam/aws_iam_grpc_credentials_test/test.log)
INFO: From Testing //test/extensions/grpc_credentials/aws_iam:aws_iam_grpc_credentials_test:
ERROR: /build/tmp/_bazel_bazel/b570b5ccd0454dc9af9f65ab1833764d/external/com_googlesource_quiche/BUILD.bazel:1988:1: C++ compilation of rule '@com_googlesource_quiche//:quic_core_framer_lib' failed (Exit 1)
bazel-out/k8-opt/bin/external/com_googlesource_quiche/quiche/quic/core/quic_framer.cc: In member function 'bool quic::QuicFramer::AppendIetfAckFrameAndTypeByte(const quic::QuicAckFrame&, quic::QuicDataWriter*)':
bazel-out/k8-opt/bin/external/com_googlesource_quiche/quiche/quic/core/quic_framer.cc:5420:40: error: comparison between signed and unsigned integer expressions [-Werror=sign-compare]
         writer->remaining() - ecn_size <
         ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^
             QuicDataWriter::GetVarInt62Len(gap) +
             ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
                 QuicDataWriter::GetVarInt62Len(ack_range)) {
                 ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

About this issue

Original URL
State: closed
Created 4 years ago
Comments: 16 (11 by maintainers)

Commits related to this issue

gfe-relnote: n/a, fix some compiler errors in QUICHE. Reported in: https://github.com/envoyproxy/envoy/issues/10422 of -Wsign-compare under GCC. https://github.com/envoyproxy/envoy/issues/10767 of mi... — committed to ls-saint/quiche by danzh1989 4 years ago

Most upvoted comments

Use --sandbox_debug to see verbose messages from the sandbox gcc: error: unrecognized command line option ‘-fno-limit-debug-info’ gcc: error: unrecognized command line option ‘-Wgnu-conditional-omitted-operand’ gcc: error: unrecognized command line option ‘-Wc++2a-extensions’; did you mean ‘-fms-extensions’? gcc: error: unrecognized command line option ‘-Wrange-loop-analysis’

clang config generated in envoy submodule isn’t being picked up by bazel when building from http-filter-example’s main dir. https://github.com/envoyproxy/envoy-filter-example/pull/139 should fix the issue.

dmitri-d on Dec 14, 2020

This issue should have been fixed in QUICHE and merged into Envoy in #13949.

danzh2010 on Dec 14, 2020

/assign @danzh2010

danzh2010 on Apr 23, 2020