granian: `1.2.0` doesn't shut down properly

When upgrading to v1.2.0 it seems the shutdown for asgi doesn’t work properly - it seems to be hanging.

About this issue

  • Original URL
  • State: closed
  • Created 3 months ago
  • Comments: 24 (16 by maintainers)

Most upvoted comments

You are right! If the route is an async def it works fine. Any CTA on this?

I’m not sure, it might be related to the way workers handle signals, but further investigations are needed.

P.S. Could you also reproduce this issue with my code above?

Not yet, I might have some time during the weekend to run tests.

@zarekr no, it’s not similar. Seems more like #186. This issue refers to shutdown.

Oops. Had the wrong issue open 🥱

sorry yes, it was on an arm on mac os using fastapi, python 3.11. both granian reload and not were affected.

i’ll try to get a reproducible example here in the next few days!

note: i did have a lifespan to create database tables