vaul: Setting dismissable=false and modal=false still triggers the component to close

Here is the behavior that I am seeing https://github.com/emilkowalski/vaul/assets/8076886/fb058903-fa8a-49b8-bc4b-739369be16eb

BEST CASE: what i want to happen is:

  1. click on two dots successfully in a row, causes the bottom sheet to stay open

MID CASE:

  1. if i click on two dots in a row, it closes and reopens for each dot

CURRENT CASE:

  1. if I click on two dots in a row. The first one opens, then the sheet doesn’t open again.
<Drawer.Root dismissible={false} open={open} modal={false}>
   <Drawer.Portal>
      ...
   </Drawer.Portal>
</Drawer.Root>

How I"m calling the Bottomsheet:

<NonDismissBottomSheet
          open={!!selectedPointData}
          setOpen={() => {
            setSelectedIndex(null);
          }}
        />

About this issue

  • Original URL
  • State: closed
  • Created 8 months ago
  • Comments: 15 (3 by maintainers)

Most upvoted comments

@xih Ok yea, I can confirm that this does work as expected after fixing #166. I’ll release a new version in the next hour.