ember.js: Unable to set 'error' route on 2.10

Ember.js is setting the ‘error’ route by default, but route-recognizer does not allow duplicate routes anymore: https://github.com/tildeio/route-recognizer/blame/5d54688f04273d3a921470b903a36266dddcdaf2/dist/route-recognizer.js#L525-L531

Doing so will give you a blank page with an error in your console:

Uncaught Error: You may not add a duplicate route named `error`

Default ‘error’ routes are set here: https://github.com/emberjs/ember.js/blob/10857fd98008bb47bd63bfe3d21b0fc224a197a5/packages/ember-routing/lib/system/dsl.js#L49-L50

You can test it by trying to handle error route using ember g route error. This functionality worked fine in 2.9 .

About this issue

Original URL
State: closed
Created 8 years ago
Reactions: 19
Comments: 29 (14 by maintainers)

Most upvoted comments

Fixed in 2.11.1

rwjblue on Feb 16, 2017

We hit this issue upgrading the Bustle app to 2.10, and we’ll need to either refactor our root error route to be named differently or hold off upgrading to 2.10.

ZeeJab on Dec 27, 2016

Since the 2.12 beta introduces a whole bunch of new issues.

Please report any issues you find with the beta cycle!

Is there any chance to get this fix backported to a 2.11 release?

Yes, I think that is a good idea.

rwjblue on Jan 31, 2017

Thanks @locks, @rwjblue I can confirm it is working.

gmaliar on Feb 18, 2017

Is there a status on this guy?

tosidsethi on Dec 20, 2016

That’s not the fix, @pixelhandler! That’s where the bug was introduced. 😜This does need a point release once fixed, but I have a few other things to address before I can get back to do the router things. (I’ve got about 5 open issues to address.)

nathanhammond on Dec 3, 2016

Seems legit. This is by virtue of a route-recognizer change I made. Need to lock out the default creation if the user has already created one. (I know how to fix, will get to it.)

nathanhammond on Nov 29, 2016