ember.js: scheduleRevalidate in canary is causing test failures
Hello! travis-web has recently started failing to build on canary. One of the errors is this:
Promise rejected after visiting /builds/branches-tab: null is not an object (evaluating 'node.ownerNode.emberView.scheduleRevalidate')
Which looks to be from this line in ember-htmlbars/lib/utils/subscribe.js:
node.ownerNode.emberView.scheduleRevalidate(node, labelFor(stream));
Looking at the history of that file, I don’t see any reason why recent changes would have produced this failure, but I’m wholly unfamiliar with this code.
Hopefully this is a helpful error report and not just a red herring. Let me know if you need any more information or if maybe it’s a problem in travis-web.
About this issue
- Original URL
- State: closed
- Created 8 years ago
- Comments: 21 (14 by maintainers)
Commits related to this issue
- Add guard against missing ownerNode This is an attempt to diagnose this issue: https://github.com/emberjs/ember.js/issues/13846 — committed to backspace/ember.js by backspace 8 years ago
- Add guard for presence of emberView This is an attempt to diagnose this issue: https://github.com/emberjs/ember.js/issues/13846 — committed to backspace/ember by backspace 8 years ago
- Change try-canary to use experimental fork See here for some background: https://github.com/emberjs/ember.js/issues/13846 — committed to travis-ci/travis-web by backspace 8 years ago
- Test @rwjblue’s scheduleRevalidate fix References: https://github.com/emberjs/ember.js/pull/14110 https://github.com/emberjs/ember.js/issues/13846 — committed to travis-ci/travis-web by backspace 8 years ago
Forgot emberx-select 😞