ember.js: replaceWith / transitionTo doesn't respect query params on beforeModel

@bgentry This seems like a bug seems that replaceWith and transition to do not work with a {queryParams:{name:'value'} argument; but work fine with using an argument for a route name.

• https://ember-twiddle.com/418933f4e91d2fa4b745f3423bd8ba8a?openFiles=routes.index.js%2C

Docs here, http://emberjs.com/api/classes/Ember.Route.html#method_transitionTo, indicate that the following should work, but the above that is not working in the above twiddle.

// if you just want to transition the query parameters without changing the route
this.transitionTo({ queryParams: { sort: 'date' } });

Adding the following to a Controller for my /auth/login route worked. Hopefully this helps others.

  queryParams: ['continue_to'],
  continue_to: null

For what it’s worth, the documentation about Redirecting does not state that query parameters must be declared in the destination Controller, but it is mentioned on the Query Parameter docs. That’s probably how I missed it. Making this more explicit in the docs may help other Ember newbies like myself.

Hmm yeah, thinking about it, the transition should work, as there are totally legit usecases for doing this unrelated to param defaults.

I wouldn’t advise doing pretty much anything in init methods most anywhere in ember, with the exception of basic object setup - you have no guarantees about when your init method would be called, it may not be the point you expect due to dependency injection laziness.

I don’t use controllers at all (I don’t have a use for them and I know they are being deprecated).

is this just not supported/possible from the beforeModel hook?

The routing guides state that redirection / transitioning in beforeModel is indeed supported. It’s something about the query-only case I think.

This doesn’t seem to be related to the recent transition work I did.

You’re not really transitioning, because your query params is not refreshModel. If you really need the default param serialized to the url, I suggest using refreshModel or using set in setupController (requires a run.next) instead, both of which do work currently.

However I think the real issue is fighting against the design of query params, which is explicitly that the default value doesn’t show in the url. Your use case is explicitly not support by ember currently so whilst there are some workarounds, I’m inclined to say this isn’t a bug, it’s just not how query params work