ember-intl: Incorrect versions/tags on NPM and docs site?

AFAICT, v6.0.0-beta.2 is currently the latest and greatest, though I’m a bit confused. 10 months ago, v6.0.0 was published to NPM: https://www.npmjs.com/package/ember-intl/v/6.0.0

And the docs site even includes v6.0.1: https://ember-intl.github.io/ember-intl/versions/v6.0.1/

About this issue

  • Original URL
  • State: closed
  • Created 2 years ago
  • Reactions: 5
  • Comments: 17 (13 by maintainers)

Most upvoted comments

I think we need to do these things:

  • Properly release v6.x and tag it as latest on npm, e.g. v6.1.0.
    • Are there any outstanding issues / incompatibilities / tasks that would prevent a proper v6.x release? Edit: yes
      • CI is broken
      • …more?
    • Do we want to include more breaking changes?
  • Check wehther we should deprecate any versions from npm.
    • e.g. v6.0.0
    • If v5.7.1 & v5.7.2 indeed include v6.x breaking changes, we should consider deprecating them, once v6.x is released and tagged as latest. However, we must evaluate, whether by doing so we risk breaking apps of users who already upgraded to these versions vs. whether there’s actually any real danger for users unwittingly installing these v6.x changes.
  • To prevent future mistakes:

Is there a changelog anywhere for what to expect in v6?

@buschtoens Thank you for looking into this and sending all these details. I don’t think I have the skills to help, but I’m impressed and supportive of your efforts to fix this 👍

I did a bit of commit archaeology. Please don’t take this as blaming. That’s not the intention at all. If anything, I’m at least partly responsible for this. I’m only trying to clarify the history, so that we can find the correct resolution. 💖

  • The last pre-confusion (😅) version was v5.6.2. Here are all commits to main since: v5.6.2...main
  • Then major changes entered main, which couldn’t be published in the v5.x series any more.
  • These were then published by @longlho as v6.0.0 and probably tagged as latest on npm, however the tag is missing on GitHub.
    • I suppose this should have been a beta instead, because of incompatibilities mentioned further down.
    • The version is currently still up on npm, but not tagged as latest.
  • In the meantime @Turbo87 fixed an Ember deprecation via ddf97609 on an extra branch based off v5.6.2. This got published as v5.7.0, as v6.0.0 wasn’t ready yet.
  • The changes were then merged to main to not lose them with the v6.0.0 release.
  • https://github.com/ember-intl/ember-intl/issues/1564#issuecomment-876636821

    Unfortunately, the main branch is in a broken state. The version got incremented to 6.0.0 and published as a beta after #1530 was merged. This PR introduced a @dependentKeyCompat decorator on _locale and AFACIT, this is one of the causes for the broken main branch. Nevertheless, I’ve published a 6.0.0-beta.1 with the latest (broken) state of main.

    I would rather invest time into stabilizing 6.0.0, as it fixes this issue as a side-effect, than fixing it for 5.7.0 and pushing out an intermediary patch release.

  • In the context of the above, I then accidentally publised v6.0.1 on npm and subsequently deprecated it.
  • I then published a first v6.0.0-beta.1 with these changes: v5.6.2...v6.0.0-beta.1
  • At this time, npm’s tags likely were:
    • latest: v5.7.0
    • beta: v6.0.0-beta.1
  • Then three docs improvements and one dependency update were merged (v6.0.0-beta.1...v6.0.0-beta.2), which @longlho published as v6.0.0-beta.2.
  • However as of now, npm’s beta tag still points to v6.0.0-beta.1.
  • Two further versions were published by @longlho: v5.7.1 & v5.7.2, which is currently tagged as latest on npm.

@longlho Can you confirm this? Specifically the last bullet point?

@bertdeblock and others:

As it has been noted, 6.0.0 had been released by accident and is not a stable version.

I’ll close this issue now, because 6.1.0 will be released soon and will mark the beginning of the 6.x series.

I’ve published v6.0.0-beta.3 and tagged it as beta. It contains: v6.0.0-beta.2...v6.0.0-beta.3

  • feat(helpers): positional options that override named options (#1633) 3f880b83
  • test: await settled in test setupIntl() to fix race condition with fake timers (#1616) f5be9b5b
  • fix: noUncheckedIndexedAccess issues (#1607) 9a10438d
  • chore: run CI on ubuntu-latest (#1609) 6e2e9a07

If you take v5.6.2 as a reference point instead, it contains: v5.6.2...v6.0.0-beta.3

for now you can use the 6.0.0-beta.2 version