element-web: The index.html is minified and breaks some automation
The minified index.html (all content in one single line) in Element-Web v1.7.28 (and maybe one or two versions prior) completely breaks (our) Ansible-automated installation and configuration scripts.
Can this please be reverted? Element still offers no proper way of customisation and almost any new elements that are introduced use hardcoded color values instead of existing color variables … it’s simple not possible to properly modify element with just the color variable definitions in config.json, and now breaking the proper HTML-structure in index.html even makes it close to impossible to automatically change/add contents in that file, like e.g. adding custom css.
Please revert this to non-minified, proper HTML.
About this issue
- Original URL
- State: closed
- Created 3 years ago
- Comments: 15 (14 by maintainers)
The content of the
index.htmlfile is not a supported API surface, so it might change at any time.This document minification was not done on purpose, but instead it happened as a side effect of upgrading. We would happily accept a PR to fix this, but it is also not a priority for the core team.
pretty sure it is quite proper & valid; https://validator.w3.org/nu/?doc=https%3A%2F%2Fapp.element.io%2F doesn’t complain about the formatting of the file.
This was not an intentional change, but likely caused by a dependency being upgraded.
Your scripts were brittle then.
Please report these specifically because this should not be happening.
Not impossible at all, you just have to write more resilient scripts that don’t break when handed VALID HTML.
Unlikely. We only call
sanitize-htmlat runtime for validating user input.@fooness it would be great if this issue was written in a way where we were inclined to interact with it. Confrontational titles, unexplained asks for reverting a change, and assumption that this is intentional all make this undesirable to look at.