element-web: reliable repro: duplicates in new room list
Description
I can reliably repro duplicates in the new room list. This repro’d on /develop and now repros on app.element.io.
Steps to reproduce
- (not sure if necessary) Have a bunch of rooms.
- it doesn’t seem to matter which lists are collapsed or expanded
- click on a low priority room so that it’s visible/active
- right click on the room, make it a favorite
- click on any other room
- expand/look at the favorite list, it will have at least two copies of the newly favorited room.
Often from this point on the list is just broken and requires a reload. Seems like some messy state somewhere.
Version information
- Platform: web (in-browser)
In this screenshot, I did the repro instructions:
- I was in
Rust (lang)(the orange icon). - I changed it’s priority.
- It didn’t move. It wouldn’t move. I collapsed the Favorite list
- I clicked on an old room i nteh room list.
- All of the sudden
Rust (lang)disappeared from Low Priority - I expanded the Favorite list and this is what it looked like:
For the web app:
- Browser: Firefox
- OS: NixOS
- URL: app.element.io
About this issue
- Original URL
- State: closed
- Created 4 years ago
- Reactions: 3
- Comments: 27 (14 by maintainers)
Commits related to this issue
- Convert room list log setting to a real setting To debug https://github.com/vector-im/riot-web/issues/14554 and https://github.com/vector-im/riot-web/issues/14508 — committed to matrix-org/matrix-react-sdk by turt2live 4 years ago
- Merge tag 'v3.27.0' into wreck/v3.27.0-wrecked * Sanitize untrusted variables from message previews before translation Fixes vector-im/element-web#18314 * Fix editing of `<sub>` & `<sup`> & `<u>` [\#... — committed to williamkray/matrix-react-sdk by deleted user 3 years ago
- Merge tag 'v1.7.34' into develop * Sanitize untrusted variables from message previews before translation Fixes vector-im/element-web#18314 * Fix editing of `<sub>` & `<sup`> & `<u>` [\#6469](https://... — committed to williamkray/element-web by deleted user 3 years ago
- Merge tag 'v1.7.34' into build * Sanitize untrusted variables from message previews before translation Fixes vector-im/element-web#18314 * Fix editing of `<sub>` & `<sup`> & `<u>` [\#6469](https://gi... — committed to boba-best/element.boba.best by BBaoVanC 3 years ago
For the record, this issue and the recent issue are different, but it’s too late to separate them now 😦
Please don’t comment “I get this too” without logs. Specifically, we need to have the advanced room logging turned on before the duplication, and the logs need to mention the room ID which is duplicating.
I seem to have found some correlation between search and switching spaces immediately after, I cant give an exact repro, but I think that direction is warm.
@colemickens @benparsons I cannot reproduce this, but can believe it exists as a bug. https://github.com/matrix-org/matrix-react-sdk/pull/5005 adds some logging, and should be on develop.element.io (or tomorrow’s nightly) shortly. Please turn on the logging from the labs tab before the issue happens again, then send logs immediately after seeing the problem.
FWIW while screenshot doesn’t have a duplicate, it does have a “ghost sticky” which’d show in that room list in every space, and eventually maybe bug out into duplicates. This issue also got fixed, so no need to re-raise it from this description.
i can confirm this triggers the bug for me as well, thanks for putting that one together @sumnerevans!
Found a (fairly) reliable repro (95+% of the time):