element-android: Space setting category doesn't show up

The space setting category doesn’t show up. This blocks users from changing settings like “Show all rooms in home space”. New app users cannot change this setting at all, forcing them into space filters when interacting with notifications for rooms in spaces (similar to the issue fixed in https://github.com/vector-im/element-android/pull/5827).

Here is where the visibility settings for the spaces category are defined: https://github.com/vector-im/element-android/blob/6b98b3023e6507b211d849d14dcb167c130cd3d4/vector/src/main/java/im/vector/app/features/settings/VectorSettingsPreferencesFragment.kt#L105-L108

Here is where isNewAppLayoutFeatureEnabled is hardcoded to true. This causes prefs.isVisible to always be false. https://github.com/vector-im/element-android/blob/6b98b3023e6507b211d849d14dcb167c130cd3d4/vector/src/main/java/im/vector/app/features/VectorFeatures.kt#L62

About this issue

  • Original URL
  • State: open
  • Created a year ago
  • Comments: 16 (3 by maintainers)

Most upvoted comments

I’m confused why this settings panel is limited to one of the layouts. The setting in question (Show all rooms in Home) applies in both layouts AFAIK.