Electron.NET: Build fails with latest electron-builder version
- Version: 5.22.13
- Target: Windows
Steps to Reproduce:
Performing a regular build with
electronize build /target win
fails since the BuildCommand seems to pass invalid CLI arguments to electron-builder.
I’m getting the following output:
C:\Project\obj\desktop\win>electron-builder . --config=./bin/electron-builder.json --platform=win32 --arch=x64
cli.js build
Build
Building:
--mac, -m, -o, --macos Build for macOS, accepts target list (see
https://goo.gl/5uHuzj). [array]
--linux, -l Build for Linux, accepts target list (see
https://goo.gl/4vwQad) [array]
--win, -w, --windows Build for Windows, accepts target list (see
https://goo.gl/jYsTEJ) [array]
--x64 Build for x64 [boolean]
--ia32 Build for ia32 [boolean]
--armv7l Build for armv7l [boolean]
--arm64 Build for arm64 [boolean]
--dir Build unpacked dir. Useful to test. [boolean]
--prepackaged, --pd The path to prepackaged app (to pack in a
distributable format)
C:\Project\obj\desktop\win>
--projectDir, --project The path to project directory. Defaults to current
working directory.
--config, -c The path to an electron-builder config. Defaults to
`electron-builder.yml` (or `json`, or `json5`), see
https://goo.gl/YFRJOM
Publishing:
--publish, -p Publish artifacts, see https://goo.gl/tSFycD
[choices: "onTag", "onTagOrDraft", "always", "never", undefined]
Other:
--help Show help [boolean]
--version Show version number [boolean]
Examples:
electron-builder -mwl build for macOS, Windows and Linux
electron-builder --linux deb tar.xz build deb and tar.xz for Linux
electron-builder --win --ia32 build for Windows ia32
electron-builder set package.json property `foo` to
-c.extraMetadata.foo=bar `bar`
electron-builder configure unicode options for NSIS
--config.nsis.unicode=false
Unknown arguments: platform, arch
Please note how the BuildCommand passes arguments for platform and arch to electron-builder, both don’t seem to be supported.
I’ve also noticed that the BuildCommand performs a global installation of electron-builder on each run, which results in always using the latest version. This seems very prone to similar errors like this due to future breaking changes in electron-builder.
Would it be possible to simply install electron-builder locally with a fixed version? That should also solve the problem of it not working on Linux. If you’re OK with that, I’d be happy to provide a PR.
Btw, this is currently totally blocking for me and I don’t have any workarounds😊
About this issue
- Original URL
- State: closed
- Created 5 years ago
- Comments: 21 (3 by maintainers)
Commits related to this issue
- Use local, fixed version for electron-builder instead of global tool This fixes #288 — committed to GeorgDangl/Electron.NET by GeorgDangl 5 years ago
- Fixed bug: Build fails with latest electron-builder version - #288 — committed to ElectronNET/Electron.NET by GregorBiswanger 5 years ago
I implemented the support for the newest electron-builder. The next update 5.22.14 will support it.
@denisHordienko, thanks for the input!
I’ve created PR #289 with the fix. Looking forward to feedback!
@GeorgDangl Thank you very much for your support!
We will gladly accept your PR. I think additional NuGet packages would only irritate.
For the new version, however, I have time until next week.
@robalexclark, it’s the same for me in my CI builds. I think you could do automate the replacement for the changed binaries in the CI environment, but that’s a route I wouldn’t want to go😉
@robertmuehsig, @GregorBiswanger, do you have an ETA for how fast you can merge this PR and create a new release? If you’re not available, I can upload a fork with the fix to NuGet to be used as temporary workaround.