electron-builder: electron-updater fails to fetch updates from GitHub
- Electron-Builder Version: 23.6.0
- Node Version: 16
- Electron Version: 21.3.3
- Electron Type (current, beta, nightly): current
- Electron Updater version: 5.2.1 (tested and 5.3.0 is also broken)
- Target: Linux+Windows
As of 2023-01-28 22:55 UTC, electron-updater stops being able to update application using GitHub.
My application: https://github.com/beyond-all-reason/BYAR-Chobby/releases/tag/v1.1861.0 Other test application using updater: https://github.com/iffy/electron-updater-example/releases/tag/v0.8.1
The issue seems to be that https://github.com/beyond-all-reason/BYAR-Chobby/releases/latest stopped returning JSON when called with Accept: application/json but always just returns HTML entirely breaking update.
About this issue
- Original URL
- State: closed
- Created a year ago
- Reactions: 5
- Comments: 17 (7 by maintainers)
👋🏻 Hey folks! This outage was an unintended consequence of a bug fix around
/releases/routing. We have no intentions of altering the current expected behavior of the releases endpoints, or REST APIs. We do not have plans to deprecate returning JSON fromhttps://github.com/{org}/{repo}/releases/latestwithAccept: application/json. We apologize for the outage and are taking steps to mitigate the possibility of this recurring in the future!GitHub Engineers have pushed a change that has reverted
releases/latestso it’s once again respecting theAccept: application/jsonoption, and once again returns json.As it is documented now, APIs against public repos can be used unauthenticated, subject to the 60 requests per hour rate limit.
I imagine this is still a very real concern. This is great information. I will circle back if I find out any other details that would unblock using the REST endpoint.
Thank you all for the discussion around this!
@djdefi this is an update scenario so the code probing this location is shipped in lots of apps already and can’t be modified.
I’m seeing the same in my repo. It looks like it’s returning an RSS feed?