electron: WindowsToastNotification::Show crashes on Windows
- Electron version: 36.7
- Operating system: Windows 8
Here’s the minidump stack trace:
Operating system: Windows NT
6.3.9600
CPU: amd64
family 6 model 26 stepping 5
4 CPUs
GPU: UNKNOWN
Crash reason: EXCEPTION_ACCESS_VIOLATION_READ
Crash address: 0xffffffffffffffff
Assertion: Unknown assertion type 0x00000000
Process uptime: 1889 seconds
Thread 0 (crashed)
0 ElectronApp.exe!brightray::WindowsToastNotification::Show(std::basic_string<wchar_t,std::char_traits<wchar_t>,std::allocator<wchar_t> > const &,std::basic_string<wchar_t,std::char_traits<wchar_t>,std::allocator
<wchar_t> > const &,GURL const &,SkBitmap const &,bool) [windows_toast_notification.cc : 129 + 0x0]
rax = 0x0000000143560001 rdx = 0x000000000013e280
rcx = 0x0000000000232de0 rbx = 0x000000000d6591b8
rsi = 0x000000000d659170 rdi = 0x000000000de1dd58
rbp = 0x000000000013e699 rsp = 0x000000000013e630
r8 = 0x0000000000000934 r9 = 0x0000000000008000
r10 = 0x0000000000000100 r11 = 0x00007ffbae5d5420
r12 = 0x6666666666666667 r13 = 0x000000000027b440
r14 = 0x000000000dcab350 r15 = 0x000000000dcab308
rip = 0x0000000140254332
Found by: given as instruction pointer in context
1 0x5f00000000000000
rbp = 0x5f000000000d6640 rsp = 0x000000000013e6a9
rip = 0x5f00000000000000
Found by: previous frame's frame pointer
The app is using standard HTML notification APIs.
About this issue
- Original URL
- State: closed
- Created 8 years ago
- Comments: 20 (7 by maintainers)
Commits related to this issue
- :checkered_flag: Notify only when enabled - Previously, we'd attempt to create a notification no matter what the user's configuration was. Microsoft advises against that, because it can create ra... — committed to felixrieseberg/brightray by felixrieseberg 8 years ago
- Update brightray for #4681 — committed to electron/electron by zcbenz 8 years ago
- :checkered_flag: Notify only when enabled - Previously, we'd attempt to create a notification no matter what the user's configuration was. Microsoft advises against that, because it can create ra... — committed to electron-archive/brightray by felixrieseberg 8 years ago
- Update brightray for #4681 — committed to deepak1556/atom-shell by zcbenz 8 years ago
- :checkered_flag: Notify only when enabled - Previously, we'd attempt to create a notification no matter what the user's configuration was. Microsoft advises against that, because it can create ra... — committed to electron/electron by felixrieseberg 8 years ago
I already know how to fix it, and I will - I’m just currently in Beijing (meaning that I’m unable to clone Google Chrome repos). I’ll fly back today - expect a fix within the next 72 hours.
I believe that this fixes the issue and prevents the race conditions (together with the new builds of Win 10), but let’s certainly revisit if the issue pops up again. If any of you would like to try my build (it’s a debug build, but the patch is in there), I’d love to see if it actually fixes things on your end, too.