electron: webview setting baseURLForDataURL crashes Electron

@Juice10 thanks for the repro! I’ve narrowed it down a little bit and opened #28765 to track that crash.

Can confirm the workaround with electron v8.0.0 Modified version of my previous attempt:

const { app, BrowserWindow, protocol } = require('electron');
const path = require('path');
app.on('ready', () => {
  protocol.registerFileProtocol('el', (request, callback) => {
    callback({ path: path.normalize(decodeURIComponent(request.url.substr(3))) });
  });
  new BrowserWindow().loadURL(
    'data:text/html;charset=UTF-8,' + encodeURIComponent('<script src="test.js"></script>'),
    { baseURLForDataURL: 'el://C:/Users/xxx/Documents/' }
  );
});

It now works fine. Thank you guys!

@burningTyger Here’s the code I tried and it works by using the file protocol hack.

const { app, BrowserWindow, protocol } = require('electron')
const path = require('path')
app.on('ready', () => {
  protocol.registerFileProtocol('tron', (request, callback) => {
    const url = request.url.substr(6)
    const file = { path: path.normalize(`${__dirname}/${url}`) }
    callback(file)
  })
  new BrowserWindow().loadURL(
    'data:text/html;charset=UTF-8,' + encodeURIComponent('<link rel="stylesheet" href="./src/css/main.css">'),
    { baseURLForDataURL: 'tron:/' }
  )
})

Just copy paste it in your index.js file and obviously you would need your own css file and path. Put some background-color: #000 to test

This is still broken in electron 10 please say this will be fixed at some point as it would be really useful to have it working correctly

protocols don’t work with webviews.

It does work with webviews, here https://github.com/vladimiry-playground/electron-quick-start-baseURLForDataURL

A little work around. If you register your own file protocol (@see https://electronjs.org/docs/api/protocol) and use that as the baseURLForDataURL the crashing stops and you can access your files.

{baseURLForDataURL: 'atom:/'}

Of course this doesn’t solve the crashing problem. 😕 It effects both the BrowserWindow and BrowserView

@nornagon I set up a Electron Fiddler of the portion of this problem that doesn’t use a custom protocol and thus doesn’t overlap with #28407 but still crashes: https://gist.github.com/7c979306285b7b8a4588261663ce5a8b

Maybe we could re-open this issue for that use case?

This bug is also not unique to linux despite the tags on this issue. I’m experiencing it on mac with electron 7.1.3. I also tried going back to v6 which as mentioned by @evanrolfe, does not cause a crash but instead causes an ERR_FAILED loading error which results in a blank webview.

@sofianguy I also tested this issue with platfom/mac and electron 8 beta and it also fails. Maybe the tags can be added as well?

It’s not the webview only specific. It crashed even if you call window.webContents.loadURL on a regular window in the case if baseURLForDataURL is specified.

A quite severe issue. @sofianguy hope it gets moved Unsorted Issues => Fixed for Next Release soon 😃