electron: macOS High Sierra: native window tabs are not showing up properly
- Electron version: 1.7.x
- Operating system: mac OS 10.13.0 (high sierra)
Expected behavior
Native tabs show up properly like in the finder:
Actual behavior
Native tabs are not showing up at all even though some space is reserved to show them:
How to reproduce
Just set tabbingIdentifier to a BrowserWindow and make sure to “View > Show Tab Bar”.
This all works fine in macOS Sierra, so it must be a regression with High Sierra. Do we maybe have some checks in the code that test for Sierra but not newer releases?
ping @tonyganch
About this issue
- Original URL
- State: closed
- Created 7 years ago
- Reactions: 32
- Comments: 26 (13 by maintainers)
😂 I have been not working for weeks
@ckerr my understanding of this “fix” is that a build-time flag was changed such as when you build Electron on macOS high sierra, native tabs are working. That “fix” has the following issues:it will not work anymore as soon as Apple releases the next version of macOS in fall this yearit will not work if someone builds Electron from sources on macOS < High SierraI am no longer convinced this is a problem with Electron (see https://github.com/Microsoft/vscode/issues/35361#issuecomment-395365519).
This really reduced my productivity for weeks 😂 Any hint if someone wants contribute to fix it sooner?
@miltonbecker unfortunately there isn’t a fix for this issue yet.
@jkleinsc yes this feature works fine in macOS < high sierra
@bpasero We do indeed.
ok @bpasero I added a new label “OS regression” to distinguish from Electron version regressions.
@jkleinsc please, is there any update on this?
@phoenixgao can your fix from your repository (https://github.com/phoenixgao/electron-high-sierra-build) be applied here?
Hi @ckerr, can you please re-open this? Please see @bpasero 's comments. There’s an Electron 2.0 build of VSCode, and the native tabs issue is not fixed.