android-tv-program-guide: Scrolling in RTL mode not working properly

Steps to Reproduce

  • Clone repo
  • Go to developer option and turn on Force RTL
  • Run the project

Can you guys tell me how can I fix this issue?

About this issue

  • Original URL
  • State: closed
  • Created 4 years ago
  • Reactions: 2
  • Comments: 20 (8 by maintainers)

Most upvoted comments

@anoopmaddasseri I have just pushed the commit with the fix. Please reopen if you see any issues.

Hello @anoopmaddasseri, @theapache64, @sathyajithrdev,

Iโ€™ve just pushed a commit to this repo, fixing the RTL issues, mainly with focus and navigation. From what Iโ€™ve read, timelines should not be reverted in RTL mode, so I kept the original timeline there. That means that the grid below and the channel view are also in the original layout (LTR). The detail view below the grid, and the toggles above are all changed to RTL mode.

Hope it works for you now, please reopen if you see any issues.

Hello @dzolnai, Gentle Reminder ๐Ÿ””

Hey @dzolnai, Thank you for the quick response. I appreciate it. ๐Ÿ‘

I believe the RTL layout direction works perfectly as you can see in the attached video above in the query section. The major issue I observe is with scrolling and focus, The program blocks donโ€™t scroll properly when traverses through the programโ€™s ( focus-walk ) in RTL. I believe Text RTL support we can address replacing the โ€œleft/rightโ€ layout properties to new โ€œstart/endโ€ equivalents. Looking forwards, Thanks.

And maybe for the detail view, the image should be on the right side, and the text labels to the left of it. ๐Ÿ‘

FYR -

image

Update: I was busy today with making RTL scrolling work. I have scrolling working, there are still some minor polishing things missing. Hopefully I can push the fix on Monday.

That means that we should flip them as well? ๐Ÿ˜ƒ

of Google Live Channels App. Timeline indicators stay in the original layout (LTR)

In your example it is reverted though.

Should we revert it then? Or is it OK as it is?

I see the issue, it will probably require multiple smaller fixes through the code. I assume that in RTL mode, the timeline and channel column should look exactly the same as in non-RTL mode. Only the text in the program blocks should start on the right side instead of left. And maybe for the detail view, the image should be on the right side, and the text labels to the left of it. Let me know if you have suggestions.

Hi! Iโ€™m currently on vacation, I can have a look on Monday.