editorconfig-vscode: Undo is broken

Please fill-in this template.

I have a question that is specific to this extension; thus, inappropriate for the main EditorConfig issue tracker.
I tried running code --disable-extensions and the issue did NOT present itself.

Issue

	Visual Studio Code	editorconfig-vscode
Version	`1.3.1`	`0.12.5`

Root `.editorconfig` File

; top-most EditorConfig file
root = true

[*]
end_of_line = lf
insert_final_newline = true
trim_trailing_whitespace = true
charset = utf-8
indent_style = space
indent_size = 4
max_line_length = 120

[*.{js,jsx}]
quote_type = single

[{scripts/plato,scripts/deps}]
quote_type = single

[*.{json,html}]
quote_type = double

[{package.json,.babelrc,*.yaml}]
indent_size = 2

Are there any other relevant .editorconfig files in your project? No

Visual Studio Code Setting	Default	User	Workspace
`editor.insertSpaces`	`true`	`true`	`true`
`editor.tabSize`	`4`	`4`	`4`
`editor.trimAutoWhitespace`	`true`	`true`	`true`
`files.autoSave`	`"off"`	`"off"`	`"off"`
`files.insertFinalNewline`	`false`	`false`	`false`
`files.trimTrailingWhitespace`	`false`	`false`	`false`

File opened

Any file in the project

Expected behavior

Undo/Redo should work as expected

Actual behavior

After saving files Undo/Redo is broken. I need to press Cmd+Z multiple times to revert the previous change. It’s like if additional changes were added to the history.

Additional comments or steps to reproduce

After updating to vscode 1.3.0 I’m started seeing this issue. If I disable editorconfig extension everything starts to work as expected.

About this issue

Original URL
State: closed
Created 6 years ago
Reactions: 1
Comments: 26 (11 by maintainers)

Most upvoted comments

Provided the fix for https://github.com/Microsoft/vscode/issues/66214 works in tomorrow’s build, this issue is fixed for me.

Tyriar on Jan 9, 2019

everything you’re saying is consistent with what I was saying before. You see this line of code? A TextEdit is created to set the end of line. This is the blessed way that vscode wants extension developers to make these kinds of adjustments.

Thanks for the link and info, I think this is the underlying issue: https://github.com/Microsoft/vscode/issues/66214

Also, your GitHub says you’re on the vscode team? Are you working on the vscode side of this issue or is that someone else?

This isn’t my area but I’m trying to expedite getting it fixed so I can use the extension again 😛

Tyriar on Jan 8, 2019

Same on MacOS with the latest vscode update. When I type something, and wait a few seconds doing other things than typing code, I have to press Cmd+Z 4 or 5 times to get what I typed removed.

maximelebastard on Dec 20, 2018