theia: VSCode Docker extensions does not work
Description
The VSCode docker extension does not load in Theia.
Reproduction Steps
- Install https://marketplace.visualstudio.com/items?itemName=PeterJausovec.vscode-docker
- Start Theia
OS and Theia version: Ubuntu 18.04 - Theia nex 0.6.0
Diagnostics:
It fails with this error
root ERROR [hosted-plugin: 12451] (node:12451) UnhandledPromiseRejectionWarning: Error: Internal error: Could not find keytar module for reading and writing passwords at /home/theia/plugins/vscode-docker/extension/dist/extension.bundle.js:263:1618389 at Function.tryCreate (/home/theia/plugins/vscode-docker/extension/dist/extension.bundle.js:263:1618481) at /home/theia/plugins/vscode-docker/extension/dist/extension.bundle.js:157:603905 at Object.t.activateInternal (/home/theia/plugins/vscode-docker/extension/dist/extension.bundle.js:157:603957) at activate (/home/theia/plugins/vscode-docker/extension/main.js:22:28) at PluginManagerExtImpl.startPlugin (/home/theia/node_modules/@theia/plugin-ext/lib/plugin/plugin-manager.js:172:73)
About this issue
- Original URL
- State: closed
- Created 5 years ago
- Reactions: 3
- Comments: 18 (8 by maintainers)
The issue seems to be fixed for newer versions of vscode-docker as
keytaris deprecated in favor of using the secrets api. In the future vscode will completely remove support forkeytar.@dinvlad we could pass it as env variable here: https://github.com/theia-ide/theia/blob/797db759bcdde66c8bbabf2ab0b041bc7d887d30/packages/plugin-ext/src/hosted/node/hosted-plugin-process.ts#L158 you can get the proper app path from here, i.e. via injecting
ApplicationPackage