theia: [git][diff][question] Dirty diff manager throws an error

when either right or left is not under version control.

It does not cause a problem, but can we handle it on the frontend? So do not execute git show when something is not under version control.

Alternatively, git backend can handle this and return either undefined or something else.

I have assigned to you, @AlexTugarev. If you believe, it should be handled on the git backend, just reassign it to me. Thanks!

About this issue

  • Original URL
  • State: closed
  • Created 6 years ago
  • Comments: 16 (16 by maintainers)

Commits related to this issue

Most upvoted comments

@kittaakos I finally understand the underlying issue here!

you are completely right, it should not produce any errors (in log). the implementation does not check for uri schemes, which is a bogus.

e.g. in comparing a tree to some other branch let’s open gitrev uris, which cannot be handled as file uris. I’ll add a guard for uris to be handled.