react-native-fast-image: Crash on Android if source is an invalid URL

If I pass as source an object like this { uri: 'INVALID_URL' } I get the following error on Android:

Error while updating property 'source' of a view managed by: FastImageView

null

Must not be null or empty

At the moment I am normalising the source using this (ugly) code to avoid the crash:

const normalisedSource = source && typeof source.uri === 'string' && !source.uri.split('https://')[1] ? null : source;

but I think it would be better if the library prevents it.

About this issue

Original URL
State: closed
Created 5 years ago
Reactions: 13
Comments: 15

Most upvoted comments

not all image start https, http ?? const normalisedSource = source && typeof source.uri === ‘string’ && !source.uri.split(‘http’)[1] ? null : source;

+12

OrangeFlavoredColdCoffee on Mar 25, 2019

I think the library itself should take of this issue, on ios it works perfectly.

z3r0c00l-2k on Dec 5, 2020

render() { return ( <FastImage source={{uri: this.getUriImage(_uri)}}/> ) }

function getUriImage(uri) { return uri !== null && uri !== undefined && uri.includes(“/”) && uri.includes(“.”) ? uri : “” }

mrminhhuy on Jun 5, 2020

render() { return ( <FastImage source={{uri: this.getUriImage(_uri)}}/> ) }

function getUriImage(uri) { return uri !== null && uri !== undefined && uri.includes(“/”) && uri.includes(“.”) ? uri : “” }

Thanks you, my problem is solved using this

cdw1p on Jul 6, 2020

not all image start https, http ?? const normalisedSource = source && typeof source.uri === ‘string’ && !source.uri.split(‘http’)[1] ? null : source;

not all images start with https or http. what about local images

osrl on Dec 11, 2019

so I need adjust every source ? It’s so Unfriendly！！！

tianliuj on Sep 3, 2019

this is log.

2019-03-28 19:29:08.185 14848-14848/E/fastimage: http://img.abc.com/o_1d6v24em310p7pib14b94gsjbha.jpg
2019-03-28 19:29:08.185 14848-14848/ E/fastimage: false
2019-03-28 19:29:08.195 14848-14848/ E/fastimage: true
2019-03-28 19:29:08.196 14848-14848/E/unknown:ViewManager: Error while updating prop source
    java.lang.reflect.InvocationTargetException
        at java.lang.reflect.Method.invoke(Native Method)


 Caused by: java.lang.ClassCastException: Value for uri cannot be cast from ReadableNativeMap to String

rj9676564 on Mar 28, 2019

not all image start https, http ??

where do i have do make this change?

leogildo10 on Jun 23, 2020