react-native-track-player: [iOS] Git submodule points to missing commit
In current dev branch ios/RNTrackPlayer/Vendor/AudioPlayer points to https://github.com/dcvz/SwiftAudio/commits/81ca1ae6413c1c301dfedc590a8a70ca2997c129 and while this commit exists on github, it seems to be removed from all branches and it’s not available when you clone the repo locally. Here is what happens when I try to fetch submodules locally:
git submodule update --init --recursive
Submodule 'ios/RNTrackPlayer/Vendor/AudioPlayer' (https://github.com/dcvz/SwiftAudio.git) registered for path 'ios/RNTrackPlayer/Vendor/AudioPlayer'
Cloning into '/Volumes/HDD/Projects/github/react-native-track-player/ios/RNTrackPlayer/Vendor/AudioPlayer'...
error: no such remote ref 81ca1ae6413c1c301dfedc590a8a70ca2997c129
Fetched in submodule path 'ios/RNTrackPlayer/Vendor/AudioPlayer', but it did not contain 81ca1ae6413c1c301dfedc590a8a70ca2997c129. Direct fetching of that commit failed.
Also trying to clone SwiftAudio repo directly and to check out 81ca1ae6413c1 commit directly fails.
@dcvz could you please take a look and update submodule to existing commit, or push a branch to SwiftAudio repo with that commit so it would be available?
About this issue
- Original URL
- State: closed
- Created 5 years ago
- Reactions: 2
- Comments: 23 (18 by maintainers)
Commits related to this issue
- Remove SwiftAudio submodule because it was pointed at a missing commit. https://github.com/react-native-kit/react-native-track-player/issues/703 https://github.com/react-native-kit/react-native-track... — committed to curiousdustin/react-native-track-player by curiousdustin 5 years ago
- Remove SwiftAudio submodule because it was pointed at a missing commit. https://github.com/react-native-kit/react-native-track-player/issues/703 https://github.com/react-native-kit/react-native-track... — committed to perushevandkhmelev-agency/react-native-track-player by curiousdustin 5 years ago
- Remove SwiftAudio submodule because it was pointed at a missing commit. https://github.com/react-native-kit/react-native-track-player/issues/703 https://github.com/react-native-kit/react-native-track... — committed to megabyt-dev/react-native-track-player by curiousdustin 5 years ago
- Remove SwiftAudio submodule because it was pointed at a missing commit. https://github.com/react-native-kit/react-native-track-player/issues/703 https://github.com/react-native-kit/react-native-track... — committed to megabyt-dev/react-native-track-player by curiousdustin 5 years ago
Thanks for the info! Glad to know I’m not the only one who is having trouble finding a way through this minefield.
@Guichaguri I’m happy to try to help out more. Where/how should we discuss what that looks like?
https://github.com/react-native-kit/react-native-track-player/commit/170c14a58d185b046b5d095cecfad43a08553f33 should fix the v2 branch, I’ll cherrypick those into the dev branch too.
Edit: Done! Let me know if everything works as expected in the latest dev or v2 branches. I’ve also cloned the fork into the org just in case it breaks again.
@Guichaguri this broken submodule thing continues to be a PITA, especially when trying to submit improvement or bugfix PRs. Every time we have to figure out how to deal with submodule missing commit. It is making contributing back to the community a real pain.
What should we do about it?
Do you have contact with @dcvz outside of this project?
@Guichaguri, It would be nice if we could get this submodule commit thing sorted.
Also, it seems @dcvz has not been active on this project for awhile. Is there any info you can share with us about if he is expected to return, or if there is anyone else that may be taking over heading up the iOS effort?
Agreed! The archived commit solved issues in the RNTP example app. Now I am applying that to my main app project. I will let you know if it doesn’t go as expected.
@biomancer, I’d like to thank you again for your info and suggestions. I tried what you mentioned about downloading the archived commit, and it seems to have fixed the majority of the troubles I was facing in https://github.com/react-native-kit/react-native-track-player/issues/709.