runtime: The build command should not change sources that are tracked by git

Only on one of my boxes I’m getting this change every time I clean -all && sync && build:

S:\corefx (master) git diff
diff --git a/src/shims/ApiCompatBaseline.netcoreapp.netfx461.txt b/src/shims/ApiCompatBaseline.netcoreapp.netfx461.txt
index f50bb15..6efa1cc 100644
--- a/src/shims/ApiCompatBaseline.netcoreapp.netfx461.txt
+++ b/src/shims/ApiCompatBaseline.netcoreapp.netfx461.txt
@@ -1,3 +1,4 @@
+DEFAULT_APPNAME Error: 0 : Unable to resolve assembly 'Assembly(Name=System.Private.CoreLib, Version=4.0.0.0, Culture=neutral, PublicKeyToken=7cec85d7bea7798e)' referenced by the implementation assembly 'Microsoft.Cci.DummyModule'.
 DEFAULT_APPNAME Error: 0 : Unable to resolve assembly 'Assembly(Name=System.Configuration, Version=4.0.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a)' referenced by the contract assembly 'Assembly(Name=System, Version=4.0.0.0, Culture=neutral, PublicKeyToken=b77a5c561934e089)'.
 DEFAULT_APPNAME Error: 0 : Unable to resolve assembly 'Assembly(Name=System.Configuration, Version=4.0.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a)' referenced by the contract assembly 'Assembly(Name=System.Runtime.Serialization, Version=4.0.0.0, Culture=neutral, PublicKeyToken=b77a5c561934e089)'.
 DEFAULT_APPNAME Error: 0 : Unable to resolve assembly 'Assembly(Name=System.Configuration, Version=4.0.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a)' referenced by the contract assembly 'Assembly(Name=System.Web, Version=4.0.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a)'.

About this issue

Original URL
State: closed
Created 7 years ago
Comments: 31 (31 by maintainers)

Most upvoted comments

Updated https://github.com/dotnet/corefx/commit/665788b83c59c2888f2c3a9ae16cdaa42394367d.

@danmosemsft did you want to put these updates under a build switch now so only folks that have that switch enabled with update them?

weshaggard on May 3, 2017

OK shouldn’t happen any more bug @weshaggard let’s both not forget to check on this periodically.

danmoseley on May 4, 2017

@CIPop yep, fair enough. Note that the baselines in the library folders don’t update the files, but they do trigger an error telling you to do /p:baselineallapoicompaterror=true.

If we did the same here most people would push without building this folder thus their CI job would fail.

The other option is to just make this build on demand eg make the project not build if baselineallapoicompaterror != true

Meantime if this is bugging you I would add this to your own gitignore for now.

danmoseley on Apr 4, 2017