runtime: System.Linq.Expressions tests failing on some PRs

Blocking clean CI on https://github.com/dotnet/runtime/pull/45022. See here for the full log.

C:\h\w\A13D08CF\w\B433097F\e>"C:\h\w\A13D08CF\p\dotnet.exe" exec --runtimeconfig System.Linq.Expressions.Tests.runtimeconfig.json --depsfile System.Linq.Expressions.Tests.deps.json xunit.console.dll System.Linq.Expressions.Tests.dll -xml testResults.xml -nologo -nocolor -notrait category=IgnoreForCI -notrait category=OuterLoop -notrait category=failing  
  Discovering: System.Linq.Expressions.Tests (method display = ClassAndMethod, method display options = None)
  Discovered:  System.Linq.Expressions.Tests (found 5646 of 5656 test cases)
  Starting:    System.Linq.Expressions.Tests (parallel test collections = on, max threads = 2)
    System.Linq.Expressions.Tests.ConvertTests.ConvertFloatToUIntTest(useInterpreter: False) [FAIL]
      Assert.Equal() Failure
      Expected: 0
      Actual:   4294967295
      Stack Trace:
        /_/src/libraries/System.Linq.Expressions/tests/Convert/ConvertTests.cs(11424,0): at System.Linq.Expressions.Tests.ConvertTests.VerifyFloatToUInt(Single value, Boolean useInterpreter)
        /_/src/libraries/System.Linq.Expressions/tests/Convert/ConvertTests.cs(3099,0): at System.Linq.Expressions.Tests.ConvertTests.ConvertFloatToUIntTest(Boolean useInterpreter)
    System.Linq.Expressions.Tests.ConvertTests.ConvertFloatToNullableUIntTest(useInterpreter: False) [FAIL]
      Assert.Equal() Failure
      Expected: 0
      Actual:   4294967295
      Stack Trace:
        /_/src/libraries/System.Linq.Expressions/tests/Convert/ConvertTests.cs(11435,0): at System.Linq.Expressions.Tests.ConvertTests.VerifyFloatToNullableUInt(Single value, Boolean useInterpreter)
        /_/src/libraries/System.Linq.Expressions/tests/Convert/ConvertTests.cs(3108,0): at System.Linq.Expressions.Tests.ConvertTests.ConvertFloatToNullableUIntTest(Boolean useInterpreter)
  Finished:    System.Linq.Expressions.Tests
=== TEST EXECUTION SUMMARY ===
   System.Linq.Expressions.Tests  Total: 35233, Errors: 0, Failed: 2, Skipped: 0, Time: 24,631s

Runfo Tracking Issue: system.linq.expressions.tests.converttests.convertfloattonullableuinttest

Build	Definition	Kind	Run Name
1025261	runtime	Rolling	net6.0-windows-Release-x86-CoreCLR_release-Windows.7.Amd64.Open
1025261	runtime	Rolling	net6.0-windows-Release-x86-CoreCLR_release-Windows.10.Amd64.ServerRS5.Open
1025261	runtime	Rolling	net6.0-windows-Release-x86-CoreCLR_release-Windows.10.Amd64.Server19H1.Open
986006	runtime	PR 47488	net6.0-windows-Debug-x86-CoreCLR_release-Windows.7.Amd64.Open
986006	runtime	PR 47488	net6.0-windows-Debug-x86-CoreCLR_release-Windows.10.Amd64.Server19H1.Open
986006	runtime	PR 47488	net6.0-windows-Release-x86-CoreCLR_release-Windows.10.Amd64.Server19H1.ES.Open
976701	runtime	Rolling	net6.0-windows-Release-x86-CoreCLR_release-Windows.7.Amd64.Open
976701	runtime	Rolling	net6.0-windows-Release-x86-CoreCLR_release-Windows.10.Amd64.ServerRS5.Open
976701	runtime	Rolling	net6.0-windows-Release-x86-CoreCLR_release-Windows.10.Amd64.Server19H1.Open
974259	runtime	PR 47488	net6.0-windows-Release-x86-CoreCLR_release-Windows.10.Amd64.Server19H1.ES.Open
974259	runtime	PR 47488	net6.0-windows-Debug-x86-CoreCLR_release-Windows.7.Amd64.Open
974259	runtime	PR 47488	net6.0-windows-Debug-x86-CoreCLR_release-Windows.10.Amd64.Server19H1.Open
974259	runtime	PR 47488	net6.0-windows-Debug-x86-CoreCLR_release-Windows.7.Amd64.Open
974259	runtime	PR 47488	net6.0-windows-Debug-x86-CoreCLR_release-Windows.10.Amd64.Server19H1.Open
974259	runtime	PR 47488	net6.0-windows-Release-x86-CoreCLR_release-Windows.10.Amd64.Server19H1.ES.Open
974259	runtime	PR 47488	net6.0-windows-Release-x86-CoreCLR_release-Windows.10.Amd64.Server19H1.ES.Open
974259	runtime	PR 47488	net6.0-windows-Release-x86-CoreCLR_release-Windows.10.Amd64.Server19H1.ES.Open
973882	runtime	Rolling	net6.0-windows-Release-x86-CoreCLR_release-Windows.7.Amd64.Open
973882	runtime	Rolling	net6.0-windows-Release-x86-CoreCLR_release-Windows.10.Amd64.ServerRS5.Open
973882	runtime	Rolling	net6.0-windows-Release-x86-CoreCLR_release-Windows.10.Amd64.Server19H1.Open
972275	runtime	PR 47488	net6.0-windows-Release-x86-CoreCLR_release-Windows.10.Amd64.Server19H1.ES.Open
972275	runtime	PR 47488	net6.0-windows-Debug-x86-CoreCLR_release-Windows.7.Amd64.Open
972275	runtime	PR 47488	net6.0-windows-Debug-x86-CoreCLR_release-Windows.10.Amd64.Server19H1.Open
971888	runtime	Rolling	net6.0-windows-Release-x86-CoreCLR_release-Windows.7.Amd64.Open
971888	runtime	Rolling	net6.0-windows-Release-x86-CoreCLR_release-Windows.10.Amd64.ServerRS5.Open
971888	runtime	Rolling	net6.0-windows-Release-x86-CoreCLR_release-Windows.10.Amd64.Server19H1.Open
966797	runtime	PR 47489	net6.0-windows-Debug-x86-CoreCLR_release-Windows.7.Amd64.Open
966797	runtime	PR 47489	net6.0-windows-Debug-x86-CoreCLR_release-Windows.10.Amd64.Server19H1.Open
966797	runtime	PR 47489	net6.0-windows-Release-x86-CoreCLR_release-Windows.10.Amd64.Server19H1.ES.Open
966790	runtime	PR 47488	net6.0-windows-Release-x86-CoreCLR_release-Windows.10.Amd64.Server19H1.ES.Open
966790	runtime	PR 47488	net6.0-windows-Debug-x86-CoreCLR_release-Windows.7.Amd64.Open
966790	runtime	PR 47488	net6.0-windows-Debug-x86-CoreCLR_release-Windows.10.Amd64.Server19H1.Open
966776	runtime	PR 47349	net6.0-windows-Debug-x86-CoreCLR_release-Windows.7.Amd64.Open
966776	runtime	PR 47349	net6.0-windows-Debug-x86-CoreCLR_release-Windows.10.Amd64.Server19H1.Open
966776	runtime	PR 47349	net6.0-windows-Release-x86-CoreCLR_release-Windows.10.Amd64.Server19H1.ES.Open
966764	runtime	PR 47483	net6.0-windows-Release-x86-CoreCLR_release-Windows.10.Amd64.Server19H1.ES.Open
966764	runtime	PR 47483	net6.0-windows-Debug-x86-CoreCLR_release-Windows.7.Amd64.Open
966764	runtime	PR 47483	net6.0-windows-Debug-x86-CoreCLR_release-Windows.10.Amd64.Server19H1.Open
966691	runtime	PR 47443	net6.0-windows-Debug-x86-CoreCLR_release-Windows.7.Amd64.Open
966691	runtime	PR 47443	net6.0-windows-Debug-x86-CoreCLR_release-Windows.10.Amd64.Server19H1.Open
966691	runtime	PR 47443	net6.0-windows-Release-x86-CoreCLR_release-Windows.10.Amd64.Server19H1.ES.Open
966691	runtime	PR 47443	net6.0-windows-Debug-x86-CoreCLR_release-Windows.7.Amd64.Open
966691	runtime	PR 47443	net6.0-windows-Debug-x86-CoreCLR_release-Windows.10.Amd64.Server19H1.Open
966691	runtime	PR 47443	net6.0-windows-Release-x86-CoreCLR_release-Windows.10.Amd64.Server19H1.ES.Open
966583	runtime	Rolling	net6.0-windows-Release-x86-CoreCLR_release-Windows.7.Amd64.Open
966583	runtime	Rolling	net6.0-windows-Release-x86-CoreCLR_release-Windows.10.Amd64.ServerRS5.Open
966583	runtime	Rolling	net6.0-windows-Release-x86-CoreCLR_release-Windows.10.Amd64.Server19H1.Open
966494	runtime	PR 47479	net6.0-windows-Debug-x86-CoreCLR_release-Windows.7.Amd64.Open
966494	runtime	PR 47479	net6.0-windows-Debug-x86-CoreCLR_release-Windows.10.Amd64.Server19H1.Open
966494	runtime	PR 47479	net6.0-windows-Release-x86-CoreCLR_release-Windows.10.Amd64.Server19H1.ES.Open
966364	runtime	PR 47040	net6.0-windows-Debug-x86-CoreCLR_release-Windows.7.Amd64.Open
966364	runtime	PR 47040	net6.0-windows-Debug-x86-CoreCLR_release-Windows.10.Amd64.Server19H1.Open
966364	runtime	PR 47040	net6.0-windows-Release-x86-CoreCLR_release-Windows.10.Amd64.Server19H1.ES.Open
966360	runtime	PR 47349	net6.0-windows-Release-x86-CoreCLR_release-Windows.10.Amd64.Server19H1.ES.Open
966360	runtime	PR 47349	net6.0-windows-Debug-x86-CoreCLR_release-Windows.7.Amd64.Open
966360	runtime	PR 47349	net6.0-windows-Debug-x86-CoreCLR_release-Windows.10.Amd64.Server19H1.Open
966305	runtime	PR 47229	net6.0-windows-Release-x86-CoreCLR_release-Windows.10.Amd64.Server19H1.ES.Open
966305	runtime	PR 47229	net6.0-windows-Debug-x86-CoreCLR_release-Windows.7.Amd64.Open
966305	runtime	PR 47229	net6.0-windows-Debug-x86-CoreCLR_release-Windows.10.Amd64.Server19H1.Open
966218	runtime	Rolling	net6.0-windows-Release-x86-CoreCLR_release-Windows.7.Amd64.Open
966218	runtime	Rolling	net6.0-windows-Release-x86-CoreCLR_release-Windows.10.Amd64.ServerRS5.Open
966218	runtime	Rolling	net6.0-windows-Release-x86-CoreCLR_release-Windows.10.Amd64.Server19H1.Open
965963	runtime	PR 47150	net6.0-windows-Debug-x86-CoreCLR_release-Windows.7.Amd64.Open
965963	runtime	PR 47150	net6.0-windows-Debug-x86-CoreCLR_release-Windows.10.Amd64.Server19H1.Open
965963	runtime	PR 47150	net6.0-windows-Release-x86-CoreCLR_release-Windows.10.Amd64.Server19H1.ES.Open
965963	runtime	PR 47150	net6.0-windows-Release-x86-CoreCLR_release-Windows.10.Amd64.Server19H1.ES.Open
965963	runtime	PR 47150	net6.0-windows-Debug-x86-CoreCLR_release-Windows.7.Amd64.Open
965963	runtime	PR 47150	net6.0-windows-Debug-x86-CoreCLR_release-Windows.10.Amd64.Server19H1.Open
965733	runtime	PR 45827	net6.0-windows-Debug-x86-CoreCLR_release-Windows.7.Amd64.Open
965733	runtime	PR 45827	net6.0-windows-Debug-x86-CoreCLR_release-Windows.10.Amd64.Server19H1.Open
965733	runtime	PR 45827	net6.0-windows-Release-x86-CoreCLR_release-Windows.10.Amd64.Server19H1.ES.Open
965733	runtime	PR 45827	net6.0-windows-Debug-x86-CoreCLR_release-Windows.7.Amd64.Open
965733	runtime	PR 45827	net6.0-windows-Debug-x86-CoreCLR_release-Windows.10.Amd64.Server19H1.Open
965733	runtime	PR 45827	net6.0-windows-Release-x86-CoreCLR_release-Windows.10.Amd64.Server19H1.ES.Open
965733	runtime	PR 45827	net6.0-windows-Debug-x86-CoreCLR_release-Windows.7.Amd64.Open
965733	runtime	PR 45827	net6.0-windows-Debug-x86-CoreCLR_release-Windows.10.Amd64.Server19H1.Open
965733	runtime	PR 45827	net6.0-windows-Release-x86-CoreCLR_release-Windows.10.Amd64.Server19H1.ES.Open
965733	runtime	PR 45827	net6.0-windows-Debug-x86-CoreCLR_release-Windows.7.Amd64.Open
965733	runtime	PR 45827	net6.0-windows-Debug-x86-CoreCLR_release-Windows.10.Amd64.Server19H1.Open
965733	runtime	PR 45827	net6.0-windows-Release-x86-CoreCLR_release-Windows.10.Amd64.Server19H1.ES.Open
965733	runtime	PR 45827	net6.0-windows-Debug-x86-CoreCLR_release-Windows.7.Amd64.Open
965733	runtime	PR 45827	net6.0-windows-Debug-x86-CoreCLR_release-Windows.10.Amd64.Server19H1.Open
965733	runtime	PR 45827	net6.0-windows-Debug-x86-CoreCLR_release-Windows.7.Amd64.Open
965733	runtime	PR 45827	net6.0-windows-Debug-x86-CoreCLR_release-Windows.10.Amd64.Server19H1.Open
965733	runtime	PR 45827	net6.0-windows-Release-x86-CoreCLR_release-Windows.10.Amd64.Server19H1.ES.Open
965733	runtime	PR 45827	net6.0-windows-Release-x86-CoreCLR_release-Windows.10.Amd64.Server19H1.ES.Open
965733	runtime	PR 45827	net6.0-windows-Debug-x86-CoreCLR_release-Windows.7.Amd64.Open
965733	runtime	PR 45827	net6.0-windows-Debug-x86-CoreCLR_release-Windows.10.Amd64.Server19H1.Open
965337	runtime	PR 47439	net6.0-windows-Debug-x86-CoreCLR_release-Windows.7.Amd64.Open
965337	runtime	PR 47439	net6.0-windows-Debug-x86-CoreCLR_release-Windows.10.Amd64.Server19H1.Open
965337	runtime	PR 47439	net6.0-windows-Release-x86-CoreCLR_release-Windows.10.Amd64.Server19H1.ES.Open
965238	runtime	PR 47301	net6.0-windows-Release-x86-CoreCLR_release-Windows.10.Amd64.Server19H1.ES.Open
965238	runtime	PR 47301	net6.0-windows-Debug-x86-CoreCLR_release-Windows.7.Amd64.Open
965238	runtime	PR 47301	net6.0-windows-Debug-x86-CoreCLR_release-Windows.10.Amd64.Server19H1.Open
964801	runtime	PR 46823	net6.0-windows-Release-x86-CoreCLR_release-Windows.10.Amd64.Server19H1.ES.Open
964801	runtime	PR 46823	net6.0-windows-Debug-x86-CoreCLR_release-Windows.7.Amd64.Open
964801	runtime	PR 46823	net6.0-windows-Debug-x86-CoreCLR_release-Windows.10.Amd64.Server19H1.Open
964801	runtime	PR 46823	net6.0-windows-Release-x86-CoreCLR_release-Windows.10.Amd64.Server19H1.ES.Open
964801	runtime	PR 46823	net6.0-windows-Debug-x86-CoreCLR_release-Windows.7.Amd64.Open
964801	runtime	PR 46823	net6.0-windows-Debug-x86-CoreCLR_release-Windows.10.Amd64.Server19H1.Open

Displaying 100 of 103 results

Build Result Summary

Day Hit Count	Week Hit Count	Month Hit Count
0	0	0

About this issue

Original URL
State: closed
Created 3 years ago
Comments: 16 (16 by maintainers)

Commits related to this issue

Re-enable tests disabled against #47374 — committed to SingleAccretion/runtime by SingleAccretion 3 years ago
Re-enable tests disabled against #47374 — committed to SingleAccretion/runtime by SingleAccretion 3 years ago
Disable folding of implementation-defined casts (#53782) * Enhance the FloatOvfToInt2 test to exercise VN paths It is not very effective right now because the "bad" combinations of types are morp... — committed to dotnet/runtime by SingleAccretion 3 years ago
Disable folding of implementation-defined casts (#53782) * Enhance the FloatOvfToInt2 test to exercise VN paths It is not very effective right now because the "bad" combinations of types are morp... — committed to radical/runtime by SingleAccretion 3 years ago

Most upvoted comments

@SingleAccretion I suspect it’s MSVC x86 specific actually, a small repro:

#include <iostream>

__declspec(noinline) float FloatMaxValue() {
    return 3.40282346638528859e+38;
}

int main() {
    std::cout << (unsigned)FloatMaxValue();
}

MSVC x64: 0
MSVC x86: 4294967295
MSVC x86 + /d2noftol3 flag: 0  (uses FPU)

Fix https://github.com/dotnet/runtime/pull/47380

EgorBo on Jan 24, 2021

@SingleAccretion the problem it seems in this transformation in gtFoldExprConst:

before:

               [000001] ------------              *  CAST      int <- uint <- float
               [000000] ------------              \--*  CNS_DBL   float  3.4028234663852886e+38    (float.MaxValue)

after:

               [000001] ------------              *  CNS_INT   int    -1

EgorBo on Jan 23, 2021