runtime: System.Globalization.Tests.DateTimeFormatInfoFirstDayOfWeek.FirstDayOfWeek fails

During .NET Core Community online Hackathon - 6/2 I cloned the repo with latest commit then I run build.cmd and build-tests.cmd which failed with following error:

System.Globalization.Tests.DateTimeFormatInfoFirstDayOfWeek.FirstDayOfWeek fails with Expected: Sunday Actual: Monday

My operating system version: Windows 10 Pro 1803 OS Build 17134.81 Windows 10 Region is set to United States, Languages to English (United States) and I changed the first day of the week from Sunday to Monday.

When I changed the first day of the week to Sunday, the test passed!

About this issue

  • Original URL
  • State: closed
  • Created 6 years ago
  • Comments: 19 (19 by maintainers)

Most upvoted comments

I use en-US on my machine so that date formats match the US but being from the UK I consider Monday the first day of the week - I admit I never bothered to change the OS setting. Outlook has its own setting.

It would be good to understand why he did that. why need to set the first day of the week to Monday for en-US?

I guess the simple answer is because you can on Windows. As long as this setting exists we should take it into consideration IMO.

@ViktorHofer maybe you could make that change.

sure.

It isn’t that unlikely thought is it since that’s how this customer intentionally set it? @ViktorHofer maybe you could make that change.

Oh sorry I misread your answer.

I believe this is failing because of this and never worked with it:

I changed the first day of the week from Sunday to Monday.