roslyn: New .editorconfig designer does not save changes
This issue has been moved from a ticket on Developer Community.
git clone https://devdiv@dev.azure.com/devdiv/DevDiv/_git/VS.CloudCache
cd VS.CloudCache
git checkout 2c9b11133a2fc8acfb9c73486d1fa5cca0703821
.\Microsoft.VisualStudio.Cache.sln
In Solution Explorer, expand the test folder and open .editorconfig.
In the designer, make a change (check a box, or in my case set SA1611 to Disabled
Save the document and close.
Expected
Git Changes shows the file has been changed on disk.
Actual
No change is applied to the file.
And BTW, since this designer now preempts the text editor opening the document, this is a regression in my ability to maintain these files from within VS.
Workaround
Use Open With... to force the text editor to open the document.
Original Comments
Feedback Bot on 5/12/2021, 07:25 PM:
We have directed your feedback to the appropriate engineering team for further evaluation. The team will review the feedback and notify you about the next steps.
Aimee Cao [MSFT] on 5/24/2021, 02:58 AM:
Thank you for your feedback!
We were unable to open the .editorconfig file in your repo and it showed up blank. we verified the .editorconfig file in the other repo and after modifying it, it showed up in the git changes window. Could you give us a simple repo that reproduces this issue?
Do other types of files show up in the git changes window after they’ve been modified?
We are looking forward to hearing from you soon.
Thanks
Why do we ask for more info?
We try to reproduce all issues reported with the information provided in the description and comments. When we can’t reproduce the issue, we ask you for more information so we can resolve the issue as quickly and efficiently as possible.
In our guidelines, you can get tips on how to provide clear and simple reproducible steps.
Andrew Arnott [MSFT] on 5/24/2021, 07:28 AM:
This no longer repros as of 31324.4.main.
Feedback Bot on 6/2/2021, 07:21 AM:
We have directed your feedback to the appropriate engineering team for further evaluation. The team will review the feedback and notify you about the next steps.
Feedback Bot on 6/2/2021, 09:41 AM:
Thank you for sharing your feedback! Our teams prioritize action on product issues with broad customer impact. See details at: https://docs.microsoft.com/en-us/visualstudio/ide/report-a-problem?view=vs-2019#faq. In case you need answers to common questions or need assisted support, be sure to use https://visualstudio.microsoft.com/vs/support/. We’ll keep you posted on any updates to this feedback.
Rasmus Wätjen on 6/7/2021, 00:51 AM:
I have this issue also. For me it is only when changing severity from Warning or Error to Suggestion.
In that case the file does not change on disk, and the file does not show as changed in the IDE.
When changing from Suggestion to Warning or Error it works as expected.
Also: If I change the severity FROM Suggestion to e.g. Warning, and change it back - without saving in the mean time, then the when I save the file, the severity is stored as Warning.
Original Solutions
Aimee Cao [MSFT] solved on 5/24/2021, 06:48 PM, 0 votes:
Thank you for your feedback! I’m going to close this as not a bug, if you encounter the issue again, please re-active it or summit a new one. Thanks for contributing to Developer Community.
Andrew Arnott [MSFT] on 6/2/2021, 07:19 AM:
Actually, this is still repro’ing. I’m on 31401.7.main now and the designer never saves changes I make to analyzer severity settings.
Jonathan Griffiths solved on 6/29/2021, 02:29 AM, 0 votes:
[Workaround]
This is a pain. The easiest workaround I’ve found is to expand the Solution Explorer > Dependencies > Analyzers and then to right-click on the rules in turn and set the severity. This seems to update the .editorConfig file.
About this issue
- Original URL
- State: open
- Created 3 years ago
- Reactions: 13
- Comments: 24 (9 by maintainers)
There’s at least three issues open for this problem (this one, #56676 and #60232) and somehow it’s still an issue after nearly a year. I don’t get how major software like this can ship with totally non-functional UI (over multiple versions!). It’s not like it’s a minor usability issue, it’s literally just completely broken and useless. I also don’t see how this is a Roslyn issue rather than a Visual Studio issue (but I have no idea how things are implemented internally so maybe it makes sense).
FWIW I’m seeing this issue while trying to set “Use Tabs” to true, but nothing changes in the file.
@CyrusNajmabadi, please bear in mind that such basic things, i.e. saving a file, usually should not be problematic in the first place. In case of an unfortunate problem, like this one, it is expected to get these VERY BASIC THINGS fixed first, before adding more immature features to the whole product. And what need of the community (bugs to be specific) has a higher priority than saving a text file which is used in all types of projects? I see no point in your argument buddy. Sorry.
@light-traveller we are a team with a given amount of resources, just like any project. Currently there are roughly 5k+ issues to get through, so that means at any time there are likely many thousands of things that don’t make the cut to get fixed given the manpower and time we have.
If these issues are very important to you though, we are an open source project and would gladly accept help and contributions here like we do for many other areas. That can allow you to get things prioritized to your need level as opposed to the need of the entire community.
Thanks!
Hello @vsfeedback , I’ve faced with a similar issue. When I was adding edc file via solution explorer then changes hasn’t been saved for the edc file. It can be resolved used follow steps:
Generate .editorconfig file from settingsbuttonIn a new project, create a file at the root using right click -> Add -> name it .editorconfig -> I didn’t choose anything thinking it’d be blank but c# class was selected so the template for this was in the file.
Open .editorconfig with double click, the ui show and populate normally but no matter what changes, there is no * beside the file name to signify you can save.
I opened it with “Open with”, then saw the tenplate for a c# class file. Deleted everything. Solved.
I’m assuming this issue is related to the refactoring tool not working for .editorconfig? i.e. The Apply button from this window does nothing.
FWIW, @CyrusNajmabadi, this is a data loss bug. Changes I’m making the editorconfig UI are getting lost.
As far as I have seen throughout the years, Microsoft almost always acts like low-budget start-ups in releasing software-even for commercial products like VS 2022! It first releases a problematic software, then waits for the community to find bugs and report issues! This makes no sense whatsoever.
How come such a wealthy huge corporation does not posses enough resources to do a clean release for God’s sake? Seriously how?