roslyn: Cannot configure severity with editorconfig for analyzer diagnostics with Location.None

What is the state of this problem? I justed startet migrating rulesets to editorconfig as “highly recommended” here: https://docs.microsoft.com/en-us/visualstudio/code-quality/use-roslyn-analyzers?view=vs-2019 I just used the conversion by VS. This changes CodeAnalysisRuleSet to MinimumRecommendedRules.ruleset.

Now CA1014 is no longer a warning and i’m unable to change this bei editorconfig. Maintaining ruleset and editorconfig is very confusing as you never know, which file is used for which rule.

This can’t be the right way…

I can’t understand how you could highly recommend something, which is working so bad.

@beho @ChrisTorng This is a known issue that will be addressed when @chsienki implements #48634 to allow user specified global config to override SDK/NuGet provided global config. Until that feature is implemented, you can workaround by disabling this rule in MSBuild props/project file:

<PropertyGroup>
  <NoWarn>$(NoWarn);CA1014</NoWarn>
</PropertyGroup>

I am going to re-open this issue so at least the consequences of Won’t fixing this can be understood and discussed at IDE design meeting. Also changing it to Area-IDE.

1. We cannot write a reliable migration tool to convert any given ruleset file into an equivalent editorconfig file, which has been requested and discussed few times with @jinujoseph @vatsalyaagrawal @mikadumont. Note that a ruleset file is independent of project context and is generally shared across multiple projects in a solution, so one cannot go from a pointed ruleset file to each applicable project and update it to add a /nowarn.

2. The existing Analyzers node’s “Set Rule Set Severity” functionality is being moved over to “Set severity” to instead update the editorconfig file with https://github.com/dotnet/roslyn/pull/37795. As the rule metadata does not indicate if it will produce no-location diagnostics, we cannot differentiate rules on when to add a configuration entry to editorconfig vs doing a /nowarn. Unfortunately, this would mean we cannot take that PR and would need to continue offering generating/editing ruleset files from Analyzers node for reliable configuration.

3. While attempting to manually update some existing project using ruleset to editorconfig, it took me considerable amount of debugging why some of the severity settings in editorconfig work and some don’t - was my syntax wrong? was some other editorconfig in my directory structure overriding it? was some other MSBuild property causing it not to be respected for some analyzer diagnostics? Explaining all this to customers would be much harder.

thx @sharwell ! It’s working 😃

@p-bojkowski The configuration needs to be placed in .globalconfig, which is the true functional replacement for a rule set file. This is like .editorconfig, except it has is_global=true (instead of root=true) at the top, and it doesn’t have file grouping section headers like [*.cs].

Hi,

when using AllEnabledByDefault (opt-out) analysis mode and trying to disable CA1014: Mark assemblies as CLSCompliant (which is no-location diagnostic) I get following warning:

Multiple global analyzer config files set the same key 'dotnet_diagnostic.ca1014.severity' in section 'Global Section'.
It has been unset.
Key was set by the following files: 'C:\Program Files\dotnet\sdk\5.0.100\Sdks\Microsoft.NET.Sdk\analyzers\build\config\AnalysisLevel_5_AllEnabledByDefault.editorconfig, C:\Users\abc\Projects\solution\src\..path_to_project..\.globalconfig'

So it seems that SDK-level globalconfig clashes with project-level one.

Am I missing something or there is no way to disable no-location warning without getting another one in opt-out mode?

Faced the same problem, workaround with global .editorconfig doesn’t work 😦 A workaround is to use<NoWarn> 😦

[*.cs]
dotnet_diagnostic.IDE0062.severity = none

Above entry in your .editorconfig should suppress all IDE0062 for files and folders under that directory.

and analyzers do work, I mean, the roslyn analyzers.