docfx: Wrong favicon.ico in _site

Title

Wrong favicon.ico in _site

Functional impact

The generated _site contains the wrong favicon.ico when _appFaviconPath is specified in docfx.json.

Minimal repro steps

Add your own favicon.ico to ./images
Add _appFaviconPath to docfx.json

Expected result

My ./images/favicon.ico should be copied to _site.

Actual result

The default docfx favicon.ico is copied to _site.

About this issue

Original URL
State: closed
Created 7 years ago
Comments: 27 (22 by maintainers)

Most upvoted comments

@smaillet Thank you for your comments and it’s really convincing. It makes sense for content to overwrite template. I will fix it. @emrgee After the fix, _appFaviconPath is not needed. Adding a resource is sufficient:

"resource": [
  {
    "files": ["favicon.ico"]
  }
]

superyyrrzz on Oct 11, 2017