aspnetcore: System.IO.Pipelines.dll in the targeting pack is not a reference assembly
The versions of System.IO.Pipelines.dll and System.Threading.Channels.dll in Microsoft.AspNetCore.App.Ref aren’t the actual reference assembly – they’re the implementation. This can cause problems later if there were to be a security issue with one of these since we don’t plan to service the targeting pack. It also means the .dlls include unnecessary bloat.
This is happening because these packages only include a lib folder. To get the ref, we’ll need to find a way to flow it from the corefx repo. (cref https://github.com/dotnet/corefx/tree/master/src/System.IO.Pipelines/ref/)
About this issue
- Original URL
- State: closed
- Created 5 years ago
- Comments: 22 (22 by maintainers)
Commits related to this issue
- Remove test workaround for fixed issue. Fixes #11206 — committed to dotnet/aspnetcore by Pilchie 5 years ago
You are right, I was basing myself on the preview6 sdk, but I do see in master that this is now part of Microsoft.NETCore.App
Looks like we’re good here. I grabbed
3.0.0-preview7.19365.7ofMicrosoft.AspNetCore.App.Refoff NuGet.org and dumped System.IO.Pipelines.dll. Looks like a refasm to me:BTW, seems like System.Threading.Channels is on the same boat. It is also in the targeting pack and it is also a lib instead of a ref. I presume you would need a fix for that as well.