arcade: Missing [assembly: AssemblyMetadata("Serviceable", "True")]
If a project is serviceable and can potentially run on .NET Framework (i.e. targets net472, netstandard2.0, etc.) it should include the following assembly-level attribute.
[assembly: AssemblyMetadata("Serviceable", "True")]
cc @Eilon
About this issue
- Original URL
- State: open
- Created 6 years ago
- Reactions: 2
- Comments: 30 (28 by maintainers)
Commits related to this issue
- Include `[AssemblyMetadata("Serviceable", "true")]` too - see dotnet/arcade#1526 — committed to dotnet/efcore by dougbu 4 years ago
- Include commit SHA in `[AssemblyInformationalVersion]` value (#22649) * Add `[AssemblyMetadata("CommitHash", ...)]` to all C# assemblies - see dotnet/arcade#5866 discussion - provide the commit SHA... — committed to dotnet/efcore by dougbu 4 years ago
- Include commit SHA in `[AssemblyInformationalVersion]` value (#22649) * Add `[AssemblyMetadata("CommitHash", ...)]` to all C# assemblies - see dotnet/arcade#5866 discussion - provide the commit SHA t... — committed to dotnet/efcore by dougbu 4 years ago
- Include commit SHA in `[AssemblyInformationalVersion]` value (#22649) (#22650) * Add `[AssemblyMetadata("CommitHash", ...)]` to all C# assemblies - see dotnet/arcade#5866 discussion - provide the c... — committed to dotnet/efcore by dougbu 4 years ago
Ok. I guess the best way to fully understand how it works is to give it a spin! Also, I’m on FR this and next week but I’ll talk to my team and see if someone has the cycles to start working on it. I’ve included details about this in https://github.com/dotnet/arcade/issues/5631
I don’t know of any other work that would address it. We still do have several packages that are .NET Standard, and our other servicing work is only related to reference assemblies, where I assume this needs to be in reference asssemblies.
Yes, add a target to Arcade that adds this attribute to the assembly if the MSBuild
Serviceableproperty isture. KoreBuild did it here.