Swashbuckle.AspNetCore: Wrong PackageReference in Swashbuckle.AspNetCore.Swagger.csproj ?
Hello.
As you can see here :
https://github.com/domaindrivendev/Swashbuckle.AspNetCore/blob/ad91d72078e1e2276824b38e2483c1d8ab6e5376/src/Swashbuckle.AspNetCore.Swagger/Swashbuckle.AspNetCore.Swagger.csproj#L21-L24
It seems that this nuget (if still supposed to be aspnetcore3 compliant), need to also target netcoreapp3.0
And this PackageReference need to be toggle featured based on $(TargetFramework),
That would be FrameworkReference for netcoreapp3.0 then ?
As you can see here :
https://www.nuget.org/packages/Microsoft.AspNetCore.Mvc.Core
Last release was 2.2.5, so it’s probably within the Metapackage (that is now part of the FrameworkReference
I’m not sure it will behave nicelly on netcoreapp3.0 + aspnetcore3.0 (blow at runtime ?) is v5.0.0 is shipped with that assembly => MissingMethodException
About this issue
- Original URL
- State: closed
- Created 5 years ago
- Comments: 15 (4 by maintainers)
Not sure what you mean by “this dependency does not exist anymore”. Follow the same link you posted and click the “+ Show More” link at the bottom of the page and you’ll see it listed.
Regarding the rest of your points, I’m not exactly sure of the point you’re trying to make - very possible a lack of knowledge/context on my side. Perhaps you could provide a concise set of repro steps that demonstrate the problem or some steps to walk me through the hypothetical chain of events you’re concerned about?
At a high level though - I will say it’s my preference to keep dependency versions as low as possible so that my library can be used by as many applications as possible without forcing them to upgrade their dependencies. I also prefer this over multi-targeting as it simplifies the Swashbuckle code/build process etc. In some cases the multi-targeting can’t be avoided but in this case the project compiles against ASP.NET 2.0.0 and works perfectly well with 3.0.0 so I prefer to keep things simple and avoid multi-targeting. If breaking change are introduced with newer version of a depenency, then I will multi-target as neccessary.