annotations: PHP7 Grouped Use Statements ignored

When I use the new PHP7 grouped use statements feature, Doctrine doesn’t use the namespace to import the annotation.

For example, this works:

use Sensio\Bundle\FrameworkExtraBundle\Configuration\Route;
use Sensio\Bundle\FrameworkExtraBundle\Configuration\Method;

class MyController
{

    /**
     * @Route("/example")
     * @Method("GET")
     */     
    public function exampleAction() {...}

}

But changing the namespaces to this fails:

use Sensio\Bundle\FrameworkExtraBundle\Configuration\{
    Route, Method
}

I’m using Doctrine Annotations 1.2.7

About this issue

Original URL
State: closed
Created 8 years ago
Comments: 20 (9 by maintainers)

Most upvoted comments

Yeah, we have to adapt, or throw an exception if a grouped use statement is detected (until we got a clean fix). A silent failure is not acceptable though.

+11

Ocramius on Apr 7, 2016

The answer is: Do not use grouped annotation. They are not even a thing in the PHP world yet.

@kayladnls “solution” is how almost developers do it today.

+10

yourwebmaker on Apr 7, 2016

It’s not a “solution” but couldn’t you easily do:

use Sensio\Bundle\FrameworkExtraBundle\Configuration as Config;

class MyController
{

    /**
     * @Config\Route("/example")
     * @Config\Method("GET")
     */     
    public function exampleAction() {...}

}

greydnls on Apr 7, 2016

Nothing but I get a ping every time someone mentions it.

GeeH on Apr 7, 2016

I submitted a pull request to fix this 3 months ago: https://github.com/doctrine/annotations/pull/69

poldridge on Apr 7, 2016

@poldridge I left comments on https://github.com/doctrine/annotations/pull/69 Nothing wrong with the patch… it’s the language that is borked (PHP grammar is broken in consistency, as always) and both your patch and PHP language needs fix.

guilhermeblanco on Apr 7, 2016

@lisachenko Just checked, and the PHP Annotations plugin supports it.

blowski on Apr 7, 2016

@lisachenko The newly released PHPStorm does allow for grouped use statements:

Support for group use statements

Enjoy full support for group use statements in PhpStorm, which includes:

Reuse of group use statements during auto-import Support of group uses during refactoring (move method, class, namespaces refactorings) Handy intentions to group or split use statements

From https://www.jetbrains.com/phpstorm/whatsnew/

blowski on Apr 7, 2016