build-push-action: v2: docker driver doesn't support auto-push

You have three possibilities atm (the first one being the more straightforward).

With docker-container driver (via setup-buildx)

jobs:
  build:
    - uses: actions/checkout@v2
    - uses: docker/setup-buildx-action@v1
    - uses: docker/login-action@v1
      with:
        registry: ${{ env.REGISTRY }}
        username: ${{ env.USER }}
        password: ${{ secrets.PASSWORD }}
    - uses: docker/build-push-action@v2
      with:
        context: .
        tags: ${{ env.REGISTRY }}/myapp:latest
        push: true

With docker driver (without setup-buildx)

jobs:
  build:
    - uses: actions/checkout@v2
    - uses: docker/login-action@v1
      with:
        registry: ${{ env.REGISTRY }}
        username: ${{ env.USER }}
        password: ${{ secrets.PASSWORD }}
    - uses: docker/build-push-action@v2
      with:
        context: .
        tags: ${{ env.REGISTRY }}/myapp:latest
        load: true
    - run: docker push ${{ env.REGISTRY }}/myapp:latest

With docker driver (with setup-buildx)

jobs:
  build:
    - uses: actions/checkout@v2
    - uses: docker/setup-buildx-action@v1
      with:
        driver: docker
    - uses: docker/login-action@v1
      with:
        registry: ${{ env.REGISTRY }}
        username: ${{ env.USER }}
        password: ${{ secrets.PASSWORD }}
    - uses: docker/build-push-action@v2
      with:
        context: .
        tags: ${{ env.REGISTRY }}/myapp:latest
        load: true
    - run: docker push ${{ env.REGISTRY }}/myapp:latest

And it should fix this current issue.

@crazy-max It doesn’t look like this issue has been fixed yet.

https://github.com/docker/buildx/pull/442

The result is the same with the setup-buildx step.

jobs:
  build:
    - uses: actions/checkout@v2

    - uses: docker/setup-buildx-action@v1
      with:
        driver: docker

    - uses: docker/login-action@v1
      with:
        registry: ${{ env.REGISTRY }}
        username: ${{ env.USER }}
        password: ${{ secrets.PASSWORD }}

    - uses: docker/build-push-action@v2
      with:
        context: .
        tags: ${{ env.REGISTRY }}/myapp:latest
        push: true

Again, I know this is an upstream limitation, but I believe it makes sense for docker/build-push-action to support this basic use case despite buildx’s lack of support for it.

I think it’s better to separate the build part from the setup part.

I agree. I really like the decision to extract login and setup from v2. 👍

In this case, the environment is already set up to use the docker driver. I don’t expect this action to change that setup. I do expect an action called docker/build-push-action to be able to push images built with docker.

Thanks for considering, and great work with v2 so far!

Ubuntu virtual environments have been updated and now use Buildx 0.5.1 so it should be available through docker/buildx#442.

@veerendra2 https://github.com/docker/build-push-action#upgrade-from-v1 https://github.com/docker/build-push-action/blob/master/UPGRADE.md

wow, seems v1 is easy to use, I can login, build and push in single step.

I started trying to use v2 to get rid of warning, did I miss anything?

name: Publish Docker image
on:
  release:
    types: [published]
jobs:
  push_to_registry:
    name: Push Docker image to GitHub Packages
    runs-on: ubuntu-latest
    steps:
      - name: Check out the repo
        uses: actions/checkout@v2
      - name: Push to GitHub Packages
        uses: docker/build-push-action@v1
        with:
          username: ${{ github.actor }}
          password: ${{ secrets.GITHUB_TOKEN }}
          registry: docker.pkg.github.com
          repository: my-org/my-repo/my-image
          tag_with_ref: true