django-cms: [feat] Without public home page, a 404 error is raised

Sorry, I did not see this. It’s a call to make between two sides:

1. Inexperienced users might go back to their site without being logged in and still see the 404 (the correct check in that case would be page_permissions.user_can_change_at_least_one_page) which nudges me to not checking permissions.
2. There might be an edge use case for the root CMS pages to purposefully raise a 404. IMHO, this is not an issue since in such a case, the solution lies in catching the root CMS page in the urls.py and redirecting to the 404 view.

My call would be to not check permissions. The second point fails to convince me. @marksweb Do you have an opinion on this?

Well spotted! Interestingly, the original call in line 29 did have the return. Can you create a PR?

@erkesado Sure!

Mongolian is great, of course, but I fear there has not been done much. The more I would appreciate any time you spent on this. To make this feasible I would suggest not to go for 100% coverage in the first step… Are you on our slack channel (https://django-cms.org/slack)?

Ruff is the linter we use and the return code of 1 indicates that it found a linting issue.

Try running ruff cms --fix.

Hi @fsbraun! Thank you very much. With your generous help, the issue has been fixed, and the related test codes have been added. There is only 1 failure left in the test. In cms/tests/test_static_analysis.py file, the test_ruff fails and throws the following error:

self.assertEqual(os.spawnv(os.P_WAIT, ruff, ["ruff", "cms", "menus"]), 0)
AssertionError: 1 != 0

But how does it relate to my change in the code? Please, give me a clue 🔢

@fsbraun, @marksweb let me fix this issue.