dj-stripe: DJSTRIPE_SUBSCRIBER_MODEL_MIGRATION_DEPENDENCY breaking in 1.2.0

Hi there!

Python: 3.6.3 Django: 1.11.5 dj-stripe: 1.2.0

In 1.2.0 it is no longer possible to use a custom subscriber model, and I think this is not intended.

How to reproduce:

  • set DJSTRIPE_SUBSCRIBER_MODEL to a custom model
  • try to set DJSTRIPE_SUBSCRIBER_MODEL_MIGRATION_DEPENDENCY to the right migration, something like 0107_create_business
  • ./manage.py migrate and ./manage.py shell, you’ll end up with an error saying that the model cannot be found

Apparently, #264 treated the issue but later, between version 1.1.0 and 1.2.0, migrations were squashed and the feature is no longer available, making the use of a custom subscriber model impossible. I had to start using 1.1.0, which is not optimal either, the migrations are super long to run, making every run of ./manage.py test very long.

Thanks! cc @kavdev

About this issue

  • Original URL
  • State: closed
  • Created 6 years ago
  • Reactions: 1
  • Comments: 15 (9 by maintainers)

Commits related to this issue

Most upvoted comments

Maybe we should have a m2m between Customer and an arbitrary model.

I want to use a Company model as a subscriber. Within a company, there are several users that can handle company settings, including billing settings. I don’t think that this is something too exotic 😄

Hmmm… Ok, I see what the problem is. Yeech, I completely skipped that we had a custom subscriber model available…

Can you explain what your models look like, roughly, and why you have a custom Subscriber model? I’d like to understand this a little better.