react-pdf: jpeg-exif: can't resolve 'fs'

@diegomura can you please create your own fork until they respond to your pull request? We are building a software that is installed by developers using either pnpm, yarn, npm or bun. We cannot have a quick fix to match them all.

if you are using yarn, you can add to your package.json:

  "resolutions": {
    "@react-pdf/image": "2.2.3",
    "@react-pdf/pdfkit": "3.0.4"
  }

it should work as a workaround for the time being

Everybody who’s using this in Next.js app dir will have this issue because the bug was introduced in an internal dependency, not in the renderer package. Even downgrading isn’t an option because it’s a minor version and package managers will install automatically the latest minor (and patch) version of pdfkit.

Agree @ThomasRedstone ! That lib does way more that what it’s used for in here though. So if my PR does not get reviewed in time I might just port the only bit we need to pdfkit (both our fork and the original repo). Can’t be halted forever. As said above I still want to give it a chance

This seems to have been introduced in https://github.com/diegomura/react-pdf/commit/a35b1ba18d293df51293600d8d56015094d222d8

It would be great if you could revert it and not release it in a minor version in the future.

for npm fix

"overrides": {
		"@react-pdf/image": "2.2.3",
		"@react-pdf/pdfkit": "3.0.4"
	},

but yes, we should wait a fix from author

@felipehv gracias por el feedback. Esta libreria la usa pdfkit desde hace ya un tiempo. Si quiero eventualmente usar el proyecto original (lo cual es deseable) tengo que lentamente solucionar las diferencias. El hecho de que no se mantenga desde el 2019 o mucho menos las estrellas que tenga no hace una libreria mejor o peor. En este caso lo importante es simplemente que utiliza una dependencia de Node que no vi al integrarlo

@diegomura no creo que sea buena idea que utilices una librería sin mantenimiento desde 2019, y con 12 estrellas en github, le bajas el nivel a esta tremenda librería que es react-pdf. Lo más razonable en mi opinión es que hagas el fork o agregues el código que uses directamente dentro de la tuya, así no disminuyes la mantenibilidad de react-pdf.

Abrazo

Submitted a change in failing lib https://github.com/zhso/jpeg-exif/pull/36

Hopefully will be included soon, otherwise I might need to fork it or find another solution

This works for me as well! thanks Next.js v14.0.4

This is working for me

	"dependencies": {
		"@react-pdf/renderer": "^3.3.3",
	},
	"pnpm": {
		"overrides": {
			"@react-pdf/image": "2.2.3",
			"@react-pdf/pdfkit": "3.0.4"
		}
	},

Submitted a change in failing lib zhso/jpeg-exif#36

Hopefully will be included soon, otherwise I might need to fork it or find another solution

it has 2y ago last commit and owner has last commit at April, looks like create you own modern version of this will be better solution. Thank you for fast responding!

This is working for me

	"dependencies": {
		"@react-pdf/renderer": "^3.3.3",
	},
	"pnpm": {
		"overrides": {
			"@react-pdf/image": "2.2.3",
			"@react-pdf/pdfkit": "3.0.4"
		}
	},

I had the same issue, using just the webpack fallback without craco worked for me.

Just added this to my nextConfig

  webpack5: true,
  webpack: (config) => {
    config.resolve.fallback = { fs: false, os: false, path: false };
    return config;
  },

Yeah, I was trying to track down the dep that was just recently updated to see if I could find it, but I couldn’t find it. It says the issue is with jpeg-exif, but that package hasn’t been updated in a million years.

Everybody who’s using this in Next.js app dir will have this issue because the bug was introduced in an internal dependency, not in the renderer package. Even downgrading isn’t an option because it’s a minor version and package managers will install automatically the latest minor (and patch) version of pdfkit.

This works with yarn:

"resolutions": {
    "@react-pdf/image": "2.2.3",
    "@react-pdf/pdfkit": "3.0.4",
    "@react-pdf/layout": "3.5.0"
  },

This may work for npm, however I have not personally tested it:

"overrides": {
    "@react-pdf/image": "2.2.3",
    "@react-pdf/pdfkit": "3.0.4",
    "@react-pdf/layout": "3.5.0"
  },

If jpeg-exif is stable there’s absolutely no reason to be jumping to fork it right away.

The fact that it’s had a total of 9 issues in its life, and this is one of them, suggests it’s a tightly scoped package that does a good job (though it’s only recently that the number of installs has jumped up!)

as a work around both yarn@4 and pnpm should be able to provide you a way to override the version of any transient dependancy you feel like you’ve no control over:

• https://pnpm.io/package_json#pnpmoverrides
• https://yarnpkg.com/configuration/manifest#resolutions