badger: Don't modify tags!
Hi, the badger is great KV-store, it really is, but I have to say after two build breaking event I’m getting tired by it.
The first one was the removal of the original 2.0.0-rc.2. Then you’ve pushed master to it (that was incompatible).
Now, again, you modified v2.0.0-rc2 to point to https://github.com/dgraph-io/badger/pull/896, which again breaks our builds (and builds for a lot of people who depend on us).
Please, stop modifying tags. All of this could have been avoided by just pushing v2.0.0-rc3 and -rc4.
What is even worst, nobody should be using v2.0.0-x tags from this repo.
By messing with them, you’ve polluted the namespace at proxy.golang.com which will be default in next release of Go (1.13). I challenge you to show me a go.mod file that uses tags for depending on badger and builds with both:
go build .
and
GOPROXY='https://proxy.golang.org` go build .
Characteristic builds errors:
missing github.com/dgraph-io/badger/go.mod and .../v2/go.mod at revision v2.0.0-rc2
go: github.com/dgraph-io/badger@v2.0.0-rc.2+incompatible: go.mod has post-v2 module path "github.com/dgraph-io/badger/v2" at revision v2.0.0-rc.2
go: error loading module requirements
About this issue
- Original URL
- State: closed
- Created 5 years ago
- Reactions: 9
- Comments: 15 (7 by maintainers)
Let’s not mangle the tags anymore, what is done is done. I think it will be just worst if we keep poking at it.
GOPROXY is a workaround we can use for the moment. I would suggest releasing
-rc3just so there is a fresh tag with all the code in a stable state between github andproxy.golang.org.Yes, ipfs-cluster has to update to go-ds-badger v0.0.5.
@Kubuxu Interesting, I’ll try poking around with those settings but still no dice. Loads of errors all across the board.
OK, I’ve decided to leave this tag as is.
If you need to go back to what the code looked like before any backwards incompatible change was made I recommend using
v1.5.5which is the actual latest release we’ve done.v1.6.0will be coming up soon, followed byv2.0.0(and their correspondingrcX).We will directly jump to
v2.0.0-rc3to avoid confusion with the existingrc2andrc.2(yes, they both exist).Again, sorry for the inconvenience, it won’t happen again.