desktop: Unexpected behaviour pressing enter/return on Clone a Repository options dialog
Description
When pressing enter/return on Clone a Repository options dialog the behaviour is unexpected and confusing
Version
- GitHub Desktop: 1.2.6
- Operating system: macOS 10.13.6 (17G65)
Steps to Reproduce
- Clone a repo from GitHub website
- Look at the Clone a Repository dialog
- Press Enter
Expected Behavior
Enter should choose the default blue Clone button
Actual Behavior
Enter activates the GitHub.com tab
Additional Information
Logs
About this issue
- Original URL
- State: closed
- Created 6 years ago
- Reactions: 3
- Comments: 16 (16 by maintainers)
Sorry, @gingerbeardman . I forgot to update. Been up the walls at work recently. I will have a look tonight but if someone wants to have a look too feel free 😃
@RobertJGabriel sure thing! Just be sure to cc me on your PR whenever you submit it.
@iAmWillShepherd Mind If I have a go at this?
Thanks for taking the time to open an issue! 🙇
@gingerbeardman Sorry, I definitely messed up while trying to follow the steps to reproduce the issue. I just checked this on a Windows 10 machine running Desktop 1.4.0 and the problem definitely exists. I’ll start looking. Again, sorry for the mistake.