desktop: Problem to upgrade the react version to 16.4
Please describe the problem you think should be solved This could be a very basic question 😃
I need to use the react-select component in the desktop app. There is a known type issue which gets fixed in @types/react 16.4.13 https://github.com/JedWatson/react-select/issues/2860 So I have to upgrade the react version in desktop in order to get the fix. I use yarn upgrade to upgrade the react version and @types/react version, but after I do this, I get tons of errors when doing yarn install.
Here are the commands I ran to reproduce the problem:
- cd into the app folder, and run
yarn upgrade react@16.4.2 - cd to the root folder, and run
yarn upgrade @types/react@16.4.18 - run
yarn install
I get tons of errors similar to: ` node_modules/@types/react/index.d.ts:2317:47 - error TS2694: Namespace ‘“C:/Users/Scott/Projects/GitHub/github-desktop/node_modules/@types/prop-types/index”’ has no exported member ‘InferProps’.
2317 ? MergePropTypes<P, PropTypes.InferProps<T>> `
About this issue
- Original URL
- State: closed
- Created 6 years ago
- Comments: 15 (8 by maintainers)
@outofambit not sure if you’re still investigating this, but check out this commit which works in dev mode on my machine: 7e8f7f170
It looks like we’re running into this issue with the typings: https://github.com/DefinitelyTyped/DefinitelyTyped/issues/28015. It looks like a fix has just been merged, but not released yet. I’m still investigating how to get around it in the meantime.
I’m trying to extend the github desktop a little bit to fit my business needs. I need the react-select control to allow my users to pick among a large set (100+) of predefined tags.