desktop: Github Desktop unexpectedly closes on version 2.6.4
Describe the bug
After I updated my Github Desktop from version 2.6.3 to 2.6.4 when I open the app and click on Fetch origin, App unexpectedly closes. I don’t have any issues with version 2.6.3. It just happened from version 2.6.4 and I cannot use Github Desktop at all.
By the way, after Github Desktop closes I still see 2-3 Github Desktio process in Task Manager. I have to kill them and launch the app again, Otherwise, it won’t open.
Version & OS
Github Desktop: 2.6.4 OS: Windows 10
Steps to reproduce the behavior
- Just click on the Fetch origin button
Expected behavior
Fetch from origin.
Actual behavior
Application closes.
Logs
2021-03-04T12:42:32.904Z - info: [ui] [AppStore] loading 189 repositories from store
2021-03-04T12:42:32.905Z - info: [ui] [AppStore] found account: sky93 (Sepehr Mohaghegh)
2021-03-04T12:42:33.195Z - info: [ui] launching: 2.6.4 (Windows 10.0.19041)
2021-03-04T12:42:33.199Z - info: [ui] execPath: 'C:\Users\Sky\AppData\Local\GitHubDesktop\app-2.6.4\GitHubDesktop.exe'
2021-03-04T12:42:37.413Z - error: [main] Error: read ECONNRESET
at TCP.onStreamRead (internal/stream_base_commons.js:205:27)
2021-03-04T12:42:38.124Z - info: [main] Error report submitted
It seems I have to revert to version 2.6.3.
About this issue
- Original URL
- State: closed
- Created 3 years ago
- Comments: 31 (15 by maintainers)
Yes I’d love too!
Just tested in safe mode. I confirm that both test versions working fine in safe mode. So your theory is correct 😃 I don’t know what’s wrong with my machine that kills the port Github Desktop listens to but as you don’t kill the server on error my issue is resolved. Thank you @sergiou87 !
Yay!! Thanks for testing that!! And I’m super happy it works. Thank you so much for your help, it was key in finding the fix 🙇♂️ 🙇♂️ 🙇♂️ 🙇♂️
@sky93 the new test build: https://s3.amazonaws.com/github-desktop/releases/2.6.7-test1-38e89bb7/GitHubDesktopSetup.exe
This one should keep the port open after getting the “couldn’t connect error”, so you can
netstatit 🤞I’m glad. Hope you can find the main cause of this issue.
I tested it with
netstat. It seems Github Desktop doesn’t open a port so obviously trampoline cannot connect to it.I don’t know what’s trampoline but I tried to test if it’s working. So I opened a port in netcat in WSL, created an environment variable called
DESKTOP_PORTand opened up trampline and it was working correctly! Look at the video I just recorded:https://user-images.githubusercontent.com/8404511/110786996-11beac00-8282-11eb-9a45-9419d9309034.mp4
Thanks for trying that build out @sky93, that’s super helpful!
The result is definitely weird 😐
The internal test is connecting to port 52537, however it’s doing that from within the app. My bet again is that there is something in your machine (like an antivirus or a firewall) preventing other binaries different than the app to connect to the port.
However you say you only have Windows Defender and its firewall and you have disabled both but it doesn’t change anything, then… 🤯
Something else you could try is running the Command Line as an Administrator (very important), and then run
netstat -qbto see if the port is open.Basically you need to follow the same steps you did to get to that screenshot, check the port number used, and then look for it in
netstat -qb | findstr <port number>like this:In theory you should see the same
LISTENINGstate for that portI checked another Windows machine and it was fine. Yeah, the problem is with my machine even though I completely disabled my antivirus. And yes I’d be happy to try it out if it’s helpful to you.
@sky93 Thank you for confirming that fix works! ❤️ As @billygriffin suggested, could you also try the latest beta (v2.6.6-beta1)? You can download it from here: https://github.com/desktop/desktop/#beta-channel
That beta will display an error message to you where the previous production build used to crash. It would be very helpful if you could try to reproduce those errors a few times and share the error messages here.
Thanks so much @sky93! A fix for this is being deployed right now to production. After that ships, we’re also going to ship something that displays and error with more information instead of crashing to our beta channel. Given that this is an exceptionally rare crash, would you be willing to try out the beta when that ships and share what the error is to help us diagnose? We’ll share that here again when it’s available (and when the fix is available on prod).
Thank you @billygriffin, No, I don’t have any special proxies or antivirus. Just using Windows Defender as my antivirus. When I open Github Desktop again I see that it fetched the origin successfully but it closes.